Re: [mmotm:master 371/385] mm/nommu.c:1248:30: error: 'vm_flags' redeclared as different kind of symbol

[Oleg Nesterov <oleg@redhat.com>]

Oh. I am really sorry. I broke NOMMU again, and this time I was really stupid.

And thanks a lot Kirill!

I am travelling till the end of the next week, can't be responsive until I return :/



On 07/24, Kirill A. Shutemov wrote:
>
> On Fri, Jul 24, 2015 at 06:46:09AM +0800, kbuild test robot wrote:
> > tree:   git://git.cmpxchg.org/linux-mmotm.git master
> > head:   61f5f835b6f06fbc233481b5d3c0afd71ecf54e8
> > commit: b9e95c5dd1134d35b6c9aeaa3967ab5b3945ba73 [371/385] mm, mpx: add "vm_flags_t vm_flags" arg to do_mmap_pgoff()
> > config: microblaze-nommu_defconfig (attached as .config)
> > reproduce:
> >   wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >   chmod +x ~/bin/make.cross
> >   git checkout b9e95c5dd1134d35b6c9aeaa3967ab5b3945ba73
> >   # save the attached .config to linux build tree
> >   make.cross ARCH=microblaze 
> > 
> > All error/warnings (new ones prefixed by >>):
> > 
> >    mm/nommu.c: In function 'do_mmap':
> > >> mm/nommu.c:1248:30: error: 'vm_flags' redeclared as different kind of symbol
> >      unsigned long capabilities, vm_flags, result;
> >                                  ^
> >    mm/nommu.c:1241:15: note: previous definition of 'vm_flags' was here
> >        vm_flags_t vm_flags,
> >                   ^
> > 
> 
> This should fix the issue:
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 530eea5af989..af2196e35013 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -1245,7 +1245,7 @@ unsigned long do_mmap(struct file *file,
>         struct vm_area_struct *vma;
>         struct vm_region *region;
>         struct rb_node *rb;
> -       unsigned long capabilities, vm_flags, result;
> +       unsigned long capabilities, result;
>         int ret;
>  
>         *populate = 0;
> @@ -1263,7 +1263,7 @@ unsigned long do_mmap(struct file *file,
>  
>         /* we've determined that we can make the mapping, now translate what we
>          * now know into VMA flags */
> -       vm_flags = determine_vm_flags(file, prot, flags, capabilities);
> +       vm_flags |= determine_vm_flags(file, prot, flags, capabilities);
>  
>         /* we're going to need to record the mapping */
>         region = kmem_cache_zalloc(vm_region_jar, GFP_KERNEL);
> -- 
>  Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>