From: Dan Carpenter <dan.carpenter@oracle.com>
To: Geliang Tang <geliangtang@163.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: make "unsigned int __force *" shorter
Date: Sun, 26 Jul 2015 19:31:06 +0300 [thread overview]
Message-ID: <20150726163106.GA5371@mwanda> (raw)
In-Reply-To: <1437919294-3833-1-git-send-email-geliangtang@163.com>
On Sun, Jul 26, 2015 at 10:01:34PM +0800, Geliang Tang wrote:
> Use macro "uip" instead of "unsigned int __force *", like "vuip" in
> arch/alpha/include/asm/core_cia.h.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
The original is easier to understand. Don't add pointless abstractions
just to get around a single 80 character line.
regards,
dan carpenter
prev parent reply other threads:[~2015-07-26 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 14:01 [PATCH] staging: comedi: make "unsigned int __force *" shorter Geliang Tang
2015-07-26 16:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726163106.GA5371@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=geliangtang@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.