From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Francesco Lavra <francescolavra.fl@gmail.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: sunxi: fix activation of system reset
Date: Sun, 26 Jul 2015 21:32:38 +0200 [thread overview]
Message-ID: <20150726193238.GM2564@lukather> (raw)
In-Reply-To: <55B32BCE.5050506@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Sat, Jul 25, 2015 at 08:25:18AM +0200, Francesco Lavra wrote:
> Commit f2147de33470 ("watchdog: sunxi: support parameterized compatible
> strings") introduced a regression in sunxi_wdt_start(), by which
> the system reset function of the watchdog is not enabled upon
> starting the watchdog. As a result, the system is not reset when the
> watchdog expires. Fix it.
>
> Signed-off-by: Francesco Lavra <francescolavra.fl@gmail.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: f2147de33470 ("watchdog: sunxi: support parameterized compatible strings")
> Cc: stable@vger.kernel.org
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] watchdog: sunxi: fix activation of system reset
Date: Sun, 26 Jul 2015 21:32:38 +0200 [thread overview]
Message-ID: <20150726193238.GM2564@lukather> (raw)
In-Reply-To: <55B32BCE.5050506@gmail.com>
On Sat, Jul 25, 2015 at 08:25:18AM +0200, Francesco Lavra wrote:
> Commit f2147de33470 ("watchdog: sunxi: support parameterized compatible
> strings") introduced a regression in sunxi_wdt_start(), by which
> the system reset function of the watchdog is not enabled upon
> starting the watchdog. As a result, the system is not reset when the
> watchdog expires. Fix it.
>
> Signed-off-by: Francesco Lavra <francescolavra.fl@gmail.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: f2147de33470 ("watchdog: sunxi: support parameterized compatible strings")
> Cc: stable at vger.kernel.org
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150726/a7d3ce57/attachment.sig>
next prev parent reply other threads:[~2015-07-26 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 6:25 [PATCH v2] watchdog: sunxi: fix activation of system reset Francesco Lavra
2015-07-25 6:25 ` Francesco Lavra
2015-07-26 19:32 ` Maxime Ripard [this message]
2015-07-26 19:32 ` Maxime Ripard
2015-08-24 9:25 ` Chen-Yu Tsai
2015-08-24 9:25 ` Chen-Yu Tsai
2015-08-24 12:49 ` Guenter Roeck
2015-08-24 12:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726193238.GM2564@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=francescolavra.fl@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.