From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755379AbbG0Dgk (ORCPT ); Sun, 26 Jul 2015 23:36:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:44640 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753517AbbG0Dgk (ORCPT ); Sun, 26 Jul 2015 23:36:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,550,1432623600"; d="scan'208";a="735980595" Date: Mon, 27 Jul 2015 03:45:37 +0800 From: Yuyang Du To: Boqun Feng Cc: mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, pjt@google.com, bsegall@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, umgwanakikbuti@gmail.com, len.brown@intel.com, rafael.j.wysocki@intel.com, arjan@linux.intel.com, fengguang.wu@intel.com Subject: Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Message-ID: <20150726194537.GD28512@intel.com> References: <1436918682-4971-1-git-send-email-yuyang.du@intel.com> <1436918682-4971-7-git-send-email-yuyang.du@intel.com> <20150722021954.GC2882@fixme-laptop.cn.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150722021954.GC2882@fixme-laptop.cn.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2015 at 10:19:54AM +0800, Boqun Feng wrote: > > > +/* Remove the runnable load generated by se from cfs_rq's runnable load average */ > > +static inline void > > +dequeue_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se) > > +{ > > + update_load_avg(se, 1); > > + > > I think we need an update_cfs_rq_load_avg() here? Because the > runnable_load_avg may not be up to date when dequeue_entity_load_avg() > is called, right? Not in update_load_avg()?