All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 1/1] xterm: x-includes and x-libraries must be set for cross-compiling
Date: Sun, 26 Jul 2015 22:02:33 +0200	[thread overview]
Message-ID: <20150726200233.GJ3770@free.fr> (raw)
In-Reply-To: <20150726214445.4b5534a1@free-electrons.com>

Thomas, All,

On 2015-07-26 21:44 +0200, Thomas Petazzoni spake thusly:
> On Sun, 26 Jul 2015 19:59:49 +0200, Yann E. MORIN wrote:
> > On 2015-07-26 20:46 +0300, kyak spake thusly:
> > > From: Mikhail Peselnik <bas@bmail.ru>
> > The From filed does not match your Signed-off-by; please fix your git
> > config with:
> > 
> >     git config --global user.name 'Mikhail Peselnik'
> >     git config --global user.email 'bas at bmail.ru'
> 
> Are you sure?
> 
> In the patch itself, I see:
> 
>   From: Mikhail Peselnik <bas@bmail.ru>
>   Signed-off-by: Mikhail Peselnik <bas@bmail.ru>

Ah, right. Then it would be:

    git conmfig --global sendemail.from 'Mikhail Peselnik <bas@bmail.ru>'

> which does match. However, it indeed doesn't match the From of the mail
> itself:
> 
>   From: kyak <bas@bmail.ru>
> 
> Which I'm not sure is related to the Git configuration. And while it's
> a bit ugly, I think it doesn't cause any problem because Git will use
> the From: from inside the patch itself in preference over the From: of
> the e-mail.

Indeed, forget what I said. I was just a bit surprised that the From
field in the mail headers did not match the SoB line; but since there's
a From field in the patch itself, all is good wrt. git keeping
authorship.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-07-26 20:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-26 17:46 [Buildroot] [PATCHv2 1/1] xterm: x-includes and x-libraries must be set for cross-compiling kyak
2015-07-26 17:59 ` Yann E. MORIN
2015-07-26 19:37   ` Romain Naour
2015-07-26 19:44   ` Thomas Petazzoni
2015-07-26 20:02     ` Yann E. MORIN [this message]
2015-07-26 19:47 ` Thomas Petazzoni
2015-07-26 21:03   ` Romain Naour
2015-07-26 21:25     ` Thomas Petazzoni
2015-07-27 14:49       ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150726200233.GJ3770@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.