From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] aiccu: remove redundant --static flag to pkg-config
Date: Sun, 26 Jul 2015 22:08:48 +0200 [thread overview]
Message-ID: <20150726200848.GL3770@free.fr> (raw)
In-Reply-To: <1437937112-13269-1-git-send-email-patrickdepinguin@gmail.com>
Thomas, All,
On 2015-07-26 20:58 +0200, Thomas De Schampheleire spake thusly:
> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
> The pkg-config tool is automatically passing --static when BR2_STATIC_LIBS
> is set (see package/pkgconf/pkgconf.mk), so no need to pass it explicitly
> from package .mk files.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/aiccu/aiccu.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/aiccu/aiccu.mk b/package/aiccu/aiccu.mk
> index fc328fd..60d65dd 100644
> --- a/package/aiccu/aiccu.mk
> +++ b/package/aiccu/aiccu.mk
> @@ -16,7 +16,7 @@ AICCU_LFDLAGS = $(TARGET_LDFLAGS)
> # aiccu forgets to link with gnutls' dependencies breaking the build when
> # linking statically
> ifeq ($(BR2_STATIC_LIBS),y)
> -AICCU_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --static --libs gnutls`
> +AICCU_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --libs gnutls`
> endif
>
> # dummy RPM_OPT_FLAGS to disable stripping
> --
> 1.8.5.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-07-26 20:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 18:58 [Buildroot] [PATCH 1/4] aiccu: remove redundant --static flag to pkg-config Thomas De Schampheleire
2015-07-26 18:58 ` [Buildroot] [PATCH 2/4] fbv: " Thomas De Schampheleire
2015-07-26 20:09 ` Yann E. MORIN
2015-07-26 18:58 ` [Buildroot] [PATCH 3/4] nmap: " Thomas De Schampheleire
2015-07-26 20:10 ` Yann E. MORIN
2015-07-26 18:58 ` [Buildroot] [PATCH 4/4] php: " Thomas De Schampheleire
2015-07-26 20:11 ` Yann E. MORIN
2015-07-26 20:08 ` Yann E. MORIN [this message]
2015-07-26 21:46 ` [Buildroot] [PATCH 1/4] aiccu: " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726200848.GL3770@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.