From: Mario Bambagini <mario.bambagini@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, andreas.dilger@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: lustre: fixed 80-char rule
Date: Mon, 27 Jul 2015 21:14:28 +0200 [thread overview]
Message-ID: <20150727191428.GA17859@lynx> (raw)
In-Reply-To: <20150726191411.GB5371@mwanda>
On Sun, Jul 26, 2015 at 10:14:11PM +0300, Dan Carpenter wrote:
> On Sat, Jul 25, 2015 at 06:22:52PM +0200, Mario Bambagini wrote:
> > This patch fixes 2 lines longer than 80 chars
> >
> > The first one is a function whose argument has been moved to next line.
> > The second one is a comment split on two lines
> >
> > The script checkpatch does not complain anymore
> >
> > Signed-off-by: Mario Bambagini <mario.bambagini@gmail.com>
> > ---
> > drivers/staging/lustre/lustre/llite/llite_capa.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
> > index 119f017..1f72066 100644
> > --- a/drivers/staging/lustre/lustre/llite/llite_capa.c
> > +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
> > @@ -70,7 +70,8 @@ static unsigned long long ll_capa_renewal_retries;
> >
> > static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa);
> >
> > -static inline void update_capa_timer(struct obd_capa *ocapa, unsigned long expiry)
> > +static inline void update_capa_timer(struct obd_capa *ocapa,
> > + unsigned long expiry)
>
> This is wrong. Run your patch through checkpatch.pl --strict and it
> will help you.
>
> regards,
> dan carpenter
>
Thank you for the hint. I'll resend the set of patches.
regards
MB
prev parent reply other threads:[~2015-07-27 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 16:22 [PATCH 1/2] staging: lustre: fixed comments without */ on a separate line Mario Bambagini
2015-07-25 16:22 ` [PATCH 2/2] staging: lustre: fixed 80-char rule Mario Bambagini
2015-07-26 19:14 ` Dan Carpenter
2015-07-26 19:48 ` [RFC PATCH] checkpatch: Make --strict the default for drivers/staging files and patches Joe Perches
2015-07-27 9:21 ` Dan Carpenter
2015-07-27 19:14 ` Mario Bambagini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150727191428.GA17859@lynx \
--to=mario.bambagini@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.