From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 2/4] ARM: imx6ul: add fec MAC refrence clock and phy fixup init
Date: Tue, 28 Jul 2015 13:17:08 +0800 [thread overview]
Message-ID: <20150728051708.GD12927@tiger> (raw)
In-Reply-To: <1437122304-20598-3-git-send-email-b38611@freescale.com>
On Fri, Jul 17, 2015 at 04:38:22PM +0800, Fugang Duan wrote:
> Add FEC MAC refrence clock init.
> Add phy fixup init for i.MX6ul 14x14 evk board that installs KSZ8081 phy.
> For the phy, there needs extra phy fixup for MII and RMII mode.
>
> Signed-off-by: Fugang Duan <b38611@freescale.com>
> ---
> arch/arm/mach-imx/mach-imx6ul.c | 43 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c
> index f206506..d4f8b6c 100644
> --- a/arch/arm/mach-imx/mach-imx6ul.c
> +++ b/arch/arm/mach-imx/mach-imx6ul.c
> @@ -9,9 +9,51 @@
> #include <linux/of_platform.h>
> #include <asm/mach/arch.h>
> #include <asm/mach/map.h>
> +#include <linux/phy.h>
> +#include <linux/regmap.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
Please group <linux/*> headers together and have them sort
alphabetically.
>
> #include "common.h"
>
> +static void __init imx6ul_enet_clk_init(void)
> +{
> + struct regmap *gpr;
> +
> + gpr = syscon_regmap_lookup_by_compatible("fsl,imx6ul-iomuxc-gpr");
> + if (!IS_ERR(gpr))
> + regmap_update_bits(gpr, IOMUXC_GPR1, IMX6UL_GPR1_ENET_CLK_DIR,
> + IMX6UL_GPR1_ENET_CLK_OUTPUT);
Is it correct to set this up for all board designs?
> + else
> + pr_err("failed to find fsl,imx6ul-iomux-gpr regmap\n");
> +
> +}
> +
> +static int ksz8081_phy_fixup(struct phy_device *dev)
> +{
> + if (dev && dev->interface == PHY_INTERFACE_MODE_MII) {
> + phy_write(dev, 0x1f, 0x8110);
> + phy_write(dev, 0x16, 0x201);
> + } else if (dev && dev->interface == PHY_INTERFACE_MODE_RMII) {
> + phy_write(dev, 0x1f, 0x8190);
> + phy_write(dev, 0x16, 0x202);
> + }
Can this be done from device tree like what 954c396756e3 (net/phy:
micrel: Add OF configuration support for ksz9021) does?
> +
> + return 0;
> +}
> +
> +#define PHY_ID_KSZ8081 0x00221560
include/linux/micrel_phy.h already has this.
Shawn
> +static void __init imx6ul_enet_phy_init(void)
> +{
> + phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff, ksz8081_phy_fixup);
> +}
> +
> +static inline void imx6ul_enet_init(void)
> +{
> + imx6ul_enet_clk_init();
> + imx6ul_enet_phy_init();
> +}
> +
> static void __init imx6ul_init_machine(void)
> {
> struct device *parent;
> @@ -21,6 +63,7 @@ static void __init imx6ul_init_machine(void)
> pr_warn("failed to initialize soc device\n");
>
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> + imx6ul_enet_init();
> imx_anatop_init();
> }
>
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2015-07-28 5:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 8:38 [PATCH v1 0/4] ARM: imx6ul: add fec1 and fec2 support for i.MX6ul 14x14 evk board Fugang Duan
2015-07-17 8:38 ` [PATCH v1 1/4] ARM: imx6ul: add fec bits to GPR syscon definition Fugang Duan
2015-07-17 8:38 ` [PATCH v1 2/4] ARM: imx6ul: add fec MAC refrence clock and phy fixup init Fugang Duan
2015-07-28 5:17 ` Shawn Guo [this message]
2015-07-28 7:12 ` Duan Andy
2015-07-17 8:38 ` [PATCH v1 3/4] ARM: dts: imx: add fec1 and fec2 nodes for SOC i.MX6UL Fugang Duan
2015-07-17 8:38 ` [PATCH v1 4/4] ARM: dts: imx6ul-14x14-evk: add fec1 and fec2 support Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728051708.GD12927@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.