From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
jasonbaron0@gmail.com, bp@alien8.de, luto@amacapital.net,
tglx@linutronix.de, rostedt@goodmis.org, will.deacon@arm.com,
liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org,
ddaney@caviumnetworks.com, benh@kernel.crashing.org,
michael@ellerman.id.au, davem@davemloft.net
Subject: Re: [RFC][PATCH 5/7] jump_label: Rework update logic
Date: Tue, 28 Jul 2015 07:54:34 +0200 [thread overview]
Message-ID: <20150728055434.GA4137@osiris> (raw)
In-Reply-To: <20150727163005.GP18673@twins.programming.kicks-ass.net>
On Mon, Jul 27, 2015 at 06:30:05PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 27, 2015 at 12:47:14PM +0200, Peter Zijlstra wrote:
> > @@ -68,13 +63,8 @@ void static_key_slow_inc(struct static_k
> > return;
> >
> > jump_label_lock();
> > + if (atomic_inc_and_test(&key->enabled))
>
> atomic_inc_return() == 1, works _much_ better.
Confirmed. With this change, the jump_label_init() patch, plus the
changes in s390 inline asm everything works for me.
There are a couple of places in s390 code where the DEFINE_STATIC_KEY_FALSE
and static_branch_likely() combination would make sense.
next prev parent reply other threads:[~2015-07-28 5:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 17:52 [RFC][PATCH 0/7] jump_label: Another (better) static_key interface Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 1/7] jump_label: Rename JUMP_LABEL_{EN,DIS}ABLE Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 2/7] jump_label: Rename JUMP_LABEL_TYPE_* Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 3/7] jump_label: Add jump_entry_key() helper Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 4/7] jump_label: Add static_key_{en,dis}able() helpers Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 5/7] jump_label: Rework update logic Peter Zijlstra
2015-07-27 9:07 ` Peter Zijlstra
2015-07-27 10:47 ` Peter Zijlstra
2015-07-27 16:30 ` Peter Zijlstra
2015-07-28 5:54 ` Heiko Carstens [this message]
2015-07-24 17:52 ` [RFC][PATCH 6/7] jump_label: Add a new static_key interface Peter Zijlstra
2015-07-27 9:24 ` Peter Zijlstra
2015-07-27 9:52 ` Peter Zijlstra
2015-07-27 10:20 ` Heiko Carstens
2015-07-27 10:47 ` Peter Zijlstra
2015-07-27 10:50 ` Peter Zijlstra
2015-07-27 10:52 ` Heiko Carstens
2015-07-27 11:03 ` Peter Zijlstra
2015-07-27 14:39 ` Peter Zijlstra
2015-07-27 10:45 ` Peter Zijlstra
2015-07-27 10:51 ` Heiko Carstens
2015-07-24 17:52 ` [RFC][PATCH 7/7] x86, tsc: Employ static_branch_likely() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728055434.GA4137@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=jasonbaron0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=luto@amacapital.net \
--cc=michael@ellerman.id.au \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rabin@rab.in \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.