From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 28 Jul 2015 10:39:07 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:33719 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27008738AbbG1IjGDX9jP (ORCPT ); Tue, 28 Jul 2015 10:39:06 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.15.1/8.14.8) with ESMTP id t6S8d50e022538; Tue, 28 Jul 2015 10:39:05 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.15.1/8.15.1/Submit) id t6S8d5xA022537; Tue, 28 Jul 2015 10:39:05 +0200 Date: Tue, 28 Jul 2015 10:39:05 +0200 From: Ralf Baechle To: Paul Burton Cc: linux-mips@linux-mips.org, Guenter Roeck , Matthew Fortune , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/16] MIPS: remove outdated comments in sigcontext.h Message-ID: <20150728083905.GE30938@linux-mips.org> References: <1438027107-24420-1-git-send-email-paul.burton@imgtec.com> <1438027107-24420-2-git-send-email-paul.burton@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438027107-24420-2-git-send-email-paul.burton@imgtec.com> User-Agent: Mutt/1.5.23 (2014-03-12) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 48478 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, Jul 27, 2015 at 12:58:12PM -0700, Paul Burton wrote: > The offsets to various fields within struct sigcontext are declared > using asm-offsets.c these days, so drop the outdated comment that talks > about keeping in sync with a no longer present file. The file was renamed not removed and the comment still applies. I've recently fixed the comment so this patch again is against would reject aside of being wrong so I'm dropping it. > diff --git a/arch/mips/include/uapi/asm/sigcontext.h b/arch/mips/include/uapi/asm/sigcontext.h > index 6c9906f..ae78902 100644 > --- a/arch/mips/include/uapi/asm/sigcontext.h > +++ b/arch/mips/include/uapi/asm/sigcontext.h > @@ -14,10 +14,6 @@ > > #if _MIPS_SIM == _MIPS_SIM_ABI32 > > -/* > - * Keep this struct definition in sync with the sigcontext fragment > - * in arch/mips/tools/offset.c > - */ > struct sigcontext { > unsigned int sc_regmask; /* Unused */ > unsigned int sc_status; /* Unused */ > @@ -45,9 +41,6 @@ struct sigcontext { > > #include > /* > - * Keep this struct definition in sync with the sigcontext fragment > - * in arch/mips/tools/offset.c > - * Ralf