From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mario Bambagini <mario.bambagini@gmail.com>
Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, andreas.dilger@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] staging: lustre: fixed 80-char rule
Date: Tue, 28 Jul 2015 17:02:15 +0530 [thread overview]
Message-ID: <20150728113215.GD15027@sudip-pc> (raw)
In-Reply-To: <1438024825-18120-2-git-send-email-mario.bambagini@gmail.com>
On Mon, Jul 27, 2015 at 09:20:22PM +0200, Mario Bambagini wrote:
> This patch fixes 2 lines longer than 80 chars
>
> The first one is a function whose argument has been moved to next line.
> The second one is a comment split on two lines
>
> Signed-off-by: Mario Bambagini <mario.bambagini@gmail.com>
> ---
<snip>
>
> -static inline void update_capa_timer(struct obd_capa *ocapa, unsigned long expiry)
> +static inline void update_capa_timer(struct obd_capa *ocapa,
> + unsigned long expiry)
You are adding a new checkpatch warning here:
"Alignment should match open parenthesis"
regards
sudip
next prev parent reply other threads:[~2015-07-28 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 19:20 [PATCH v2 1/5] staging: lustre: fixed comments without */ on a separate line Mario Bambagini
2015-07-27 19:20 ` [PATCH v2 2/5] staging: lustre: fixed 80-char rule Mario Bambagini
2015-07-28 11:32 ` Sudip Mukherjee [this message]
2015-07-27 19:20 ` [PATCH v2 3/5] staging: lustre: fix bad alignment Mario Bambagini
2015-07-27 20:03 ` Dan Carpenter
2015-07-28 11:35 ` Sudip Mukherjee
2015-07-27 19:20 ` [PATCH v2 4/5] staging: lustre: added a space between concatenated strings Mario Bambagini
2015-07-27 19:20 ` [PATCH v2 5/5] staging: lustre: modified comparisons against NULL Mario Bambagini
2015-07-27 20:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728113215.GD15027@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.bambagini@gmail.com \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.