From: Viresh Kumar <viresh.kumar@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
nm@ti.com, sboyd@codeaurora.org
Subject: Re: [PATCH 0/4] cpufreq/opp: Turbo/boost mode support
Date: Tue, 28 Jul 2015 19:17:31 +0530 [thread overview]
Message-ID: <20150728134731.GA12877@linux> (raw)
In-Reply-To: <2234559.Zs4Lk1DPT6@amdc1976>
On 28-07-15, 15:38, Bartlomiej Zolnierkiewicz wrote:
> I did look a them and they are lacking enabling of boost support flag
> in cpufreq_dt driver structure.
That's insulting now, I forgot to add this:
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 217928de2f0e..db4390ca5243 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -2495,6 +2495,8 @@ int cpufreq_enable_boost_support(void)
if (cpufreq_boost_supported())
return 0;
+ cpufreq_driver->boost_supported = true;
+
/* This will get removed on driver unregister */
return create_boost_sysfs_file();
}
So that is done from the above routine now.
> There is also CONFIG_CPU_FREQ_BOOST_SW which needs to be enabled to
> have boost frequencies in sysfs (code for that is in freq_table.c).
Yeah, we should get rid of that as well..
> > those config options required. Get rid of them :)
>
> Do you mean that we should now depend only on dts info for enabling
> boost support and that CONFIG_CPU_FREQ_BOOST_SW should be removed
> (together with CONFIG_ARM_EXYNOS_CPU_FREQ_BOOST_SW)?
Yes.
--
viresh
prev parent reply other threads:[~2015-07-28 13:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 11:19 [PATCH 0/4] cpufreq/opp: Turbo/boost mode support Viresh Kumar
2015-07-28 11:20 ` [PATCH 1/4] opp: add dev_pm_opp_is_turbo() helper Viresh Kumar
2015-07-28 11:20 ` Viresh Kumar
2015-07-28 14:27 ` Pavel Machek
2015-07-29 10:24 ` Viresh Kumar
2015-07-29 10:53 ` Pavel Machek
2015-07-29 10:56 ` Viresh Kumar
2015-07-28 11:20 ` [PATCH 2/4] cpufreq: Update boost flag while initializing freq table from OPPs Viresh Kumar
2015-07-28 11:20 ` Viresh Kumar
2015-07-28 11:20 ` [PATCH 3/4] cpufreq: Allow drivers to enable boost support after registering driver Viresh Kumar
2015-07-28 11:20 ` Viresh Kumar
2015-07-28 13:48 ` Viresh Kumar
2015-07-28 11:20 ` [PATCH 4/4] cpufreq: dt: Add support for turbo/boost mode Viresh Kumar
2015-07-28 11:20 ` Viresh Kumar
2015-07-28 11:22 ` [PATCH 0/4] cpufreq/opp: Turbo/boost mode support Viresh Kumar
2015-07-28 11:55 ` Bartlomiej Zolnierkiewicz
2015-07-28 12:18 ` Viresh Kumar
2015-07-28 13:38 ` Bartlomiej Zolnierkiewicz
2015-07-28 13:47 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728134731.GA12877@linux \
--to=viresh.kumar@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.