Re: [PATCH 3/3] qemu_git.bb: remove it

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 4735 bytes --]

On Tue, Jul 28, 2015 at 02:04:28PM +0000, Iorga, Cristian wrote:
> Hi Robert,
> 
> Hmm,
> Qemu git recipe is useful, and is close to being up to date, why to remove it??

Close to being up to date? Aren't you talking about
./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb?

bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep
PV.*= {} \;
REALPV = "2.4.0-rc2"
PV = "2.3.99+${REALPV}"
PV = "1.3.0+git${SRCPV}"

As Robert said, 1.3 version is old and current qemu_git recipe broken,
because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch
anymore after it was moved to stable-1.3 branch:

bitbake@jama:/OE/projects/qemu$ git branch -a --contains 04024dea2674861fcf13582a77b58130c67fccd8
  remotes/origin/stable-1.3

> Qemu brakes quite often, as seen recently on autobuilders, building from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.)
> I vote against this patch.

Regards,
> 
> Thanks,
> Cristian
> 
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Robert Yang
> Sent: Tuesday, July 28, 2015 12:05 PM
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it
> 
> Remove it since we have 2.4.0, the git version is 1.3 can't be built by
> deafult:
> ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream
> 
> We can fix it, but seems that no one uses it any more.
> 
> And move patches from "files" dir to "qemu" dir.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  ...-Arm-versatilepb-Add-memory-size-checking.patch |    0
>  .../exclude-some-arm-EABI-obsolete-syscalls.patch  |    0
>  .../qemu-enlarge-env-entry-size.patch              |    0
>  meta/recipes-devtools/qemu/qemu_git.bb             |   15 ---------------
>  4 files changed, 15 deletions(-)
>  rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%)  rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%)  rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%)  delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb
> 
> diff --git a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
> similarity index 100%
> rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
> rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
> diff --git a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch
> similarity index 100%
> rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch
> rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch
> diff --git a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch
> similarity index 100%
> rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch
> rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch
> diff --git a/meta/recipes-devtools/qemu/qemu_git.bb b/meta/recipes-devtools/qemu/qemu_git.bb
> deleted file mode 100644
> index a30932a..0000000
> --- a/meta/recipes-devtools/qemu/qemu_git.bb
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -require qemu.inc
> -
> -SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8"
> -
> -LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
> -                    file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913"
> -
> -PV = "1.3.0+git${SRCPV}"
> -
> -SRC_URI_prepend = "git://git.qemu.org/qemu.git"
> -S = "${WORKDIR}/git"
> -
> -DEFAULT_PREFERENCE = "-1"
> -
> -COMPATIBLE_HOST_class-target_mips64 = "null"
> --
> 1.7.9.5
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]