From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
jolsa@kernel.org
Subject: Re: [PATCH] perf, tools, stat: Fix perf stat -T
Date: Tue, 28 Jul 2015 11:32:57 -0300 [thread overview]
Message-ID: <20150728143257.GC575@kernel.org> (raw)
In-Reply-To: <20150728143018.GF28175@krava.brq.redhat.com>
Em Tue, Jul 28, 2015 at 04:30:18PM +0200, Jiri Olsa escreveu:
> On Tue, Jul 28, 2015 at 11:21:32AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jul 28, 2015 at 04:10:06PM +0200, Jiri Olsa escreveu:
> > > On Mon, Jul 27, 2015 at 04:24:51PM -0700, Andi Kleen wrote:
> > > > +++ b/tools/perf/util/stat-shadow.c
> > > > + update_stats(&runtime_cycles_in_tx_stats[ctx][cpu], count[0]);
> > > oops, looks like copy&paste issue.. thanks
> > > we now print comment line if the avg is 0, but I think it's ok
> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > This affects just perf/core, right?
> I guess, dont think it's an urgent one.. Andi, please speak up ;-)
I'm not talking about it being urgent or not, I'm talking about it being
a bug present only in perf/core or if this is something that is in
perf/urgent, i.e. affects what is in Linus's upstream tree, etc.
- Arnaldo
next prev parent reply other threads:[~2015-07-28 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 23:24 [PATCH] perf, tools, stat: Fix perf stat -T Andi Kleen
2015-07-28 14:10 ` Jiri Olsa
2015-07-28 14:21 ` Arnaldo Carvalho de Melo
2015-07-28 14:30 ` Jiri Olsa
2015-07-28 14:32 ` Arnaldo Carvalho de Melo [this message]
2015-07-28 14:37 ` Jiri Olsa
2015-07-28 17:25 ` Andi Kleen
2015-07-31 13:48 ` [tip:perf/core] perf stat: Fix transaction lenght metrics tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728143257.GC575@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.