From: Greg KH <gregkh@linuxfoundation.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: dgnc_neo.c: Style and spelling fixes
Date: Tue, 28 Jul 2015 07:56:32 -0700 [thread overview]
Message-ID: <20150728145632.GB19733@kroah.com> (raw)
In-Reply-To: <20150728124805.GA6423@Karyakshetra>
On Tue, Jul 28, 2015 at 06:18:05PM +0530, Bhaktipriya Shridhar wrote:
> This patch fixes:
> 1.Fixes comments that are over 80-characters either by:
> -breaking up comment lines, into multi-line comments (kernel style) or
> -shortening comments (Done in 7 places):
> - Changed "Why?Becuz" to "Since" (6 places)
> - Removed the comment "Which I dont care about" (1 place)
> 2.Fixes code lines that are over 80-characters by
> -breaking up long math lines
> -breaking up long function calls
> 2.Spelling errors in comments.
> -tho -> though
> -baudrate -> baud rate
When listing all of the different things your patch does, that should be
a huge hint that it should be broken up into lots of different patches.
Please do only one thing per patch.
thanks,
greg k-h
prev parent reply other threads:[~2015-07-28 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 12:48 [PATCH] staging: dgnc: dgnc_neo.c: Style and spelling fixes Bhaktipriya Shridhar
2015-07-28 14:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728145632.GB19733@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhaktipriya96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.