From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Thomas Huth <thuth@redhat.com>,
slof@lists.ozlabs.org, nikunj@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [SLOF] [SLOF PATCH 2/2] fbuffer: Use a smaller cursor
Date: Tue, 28 Jul 2015 22:42:21 -0500 [thread overview]
Message-ID: <20150729034221.GE28839@gate.crashing.org> (raw)
In-Reply-To: <55B8430C.8060008@ozlabs.ru>
On Wed, Jul 29, 2015 at 01:05:48PM +1000, Alexey Kardashevskiy wrote:
> > : fb8-toggle-cursor ( -- )
> > line# fb8-line2addr column# fb8-columns2bytes +
> >- char-height 0 ?DO
> >+ char-height 3 - screen-width screen-depth * * +
> >+ 3 0 ?DO
>
> Why not just:
>
> - char-height 0 ?DO
> + 1 0 ?DO
>
> ? What is this magic with screen-width about?
Thomas' patch draws the cursor as the bottom three lines of a
character cell; your suggestion would draw it as the top one line.
But indeed it could be
char-height dup 3 - ?DO ...
Segher
next prev parent reply other threads:[~2015-07-29 3:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 10:19 [SLOF PATCH 0/2] fbuffer: Improve the speed of the cursor drawing Thomas Huth
2015-07-28 10:19 ` [SLOF PATCH 1/2] fbuffer: Improve invert-region helper Thomas Huth
2015-07-28 17:04 ` Segher Boessenkool
2015-07-28 21:00 ` Thomas Huth
2015-07-28 10:19 ` [SLOF PATCH 2/2] fbuffer: Use a smaller cursor Thomas Huth
2015-07-29 3:05 ` Alexey Kardashevskiy
2015-07-29 3:42 ` Segher Boessenkool [this message]
2015-07-29 6:03 ` [SLOF] " Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729034221.GE28839@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=slof@lists.ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.