From: hch@infradead.org (Christoph Hellwig)
Subject: SGL support of driver
Date: Wed, 29 Jul 2015 00:55:57 -0700 [thread overview]
Message-ID: <20150729075557.GA11755@infradead.org> (raw)
In-Reply-To: <20150728143500.GX13681@linux.intel.com>
On Tue, Jul 28, 2015@10:35:00AM -0400, Matthew Wilcox wrote:
> On Mon, Jul 27, 2015@09:57:56AM -0700, Christoph Hellwig wrote:
> > It also requires pagecache I/O to be split into multiple commands
> > where other block devices can handle it a lot more efficiently.
>
> Wait, what? pagecache I/O is page aligned and page sized. That can
> always be represented by a PRP list.
Pagecache I/O is not nessecarily page aligned.
Think of this case thay I remember clearly because it exposed a bug
a few years ago:
64k page size, 4k file system block size, raid 0 with a stripe size of
8k and two legs.
The typical SGL feds to the hardware driver for streaming I/O will be:
page A, offset 0, len 8k
page A, offset 16k, len 8k
page A, offset 32k, len 8k
page A, offset 48k, len 8k
page B, offset 0, len 8k
This is clearly something PRP list will not handle well. Note that I'm
not nessecarily saying this is soemthing to optimize for, the more
interesting case for NVMe really is the vectored direct I/O case.
next prev parent reply other threads:[~2015-07-29 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 16:22 SGL support of driver sheng qiu
2015-07-27 16:31 ` Christoph Hellwig
2015-07-27 16:50 ` Keith Busch
2015-07-27 16:57 ` Christoph Hellwig
2015-07-27 17:13 ` Keith Busch
2015-07-28 14:35 ` Matthew Wilcox
2015-07-29 7:55 ` Christoph Hellwig [this message]
2015-07-29 14:28 ` Keith Busch
2015-07-30 18:38 ` Matthew Wilcox
2015-07-31 7:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729075557.GA11755@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.