From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: Regression in guest destruction caused by altp2m Date: Wed, 29 Jul 2015 11:03:31 +0100 Message-ID: <20150729100330.GV5111@zion.uk.xensource.com> References: <20150727151815.GB5111@zion.uk.xensource.com> <20150727180939.GC5111@zion.uk.xensource.com> <55B6BD0C.7030107@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKOEO-00029E-4W for xen-devel@lists.xenproject.org; Wed, 29 Jul 2015 10:05:00 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Sahita, Ravi" Cc: Wei Liu , George Dunlap , Andrew Cooper , "tim@xen.org" , "White, Edmund H" , Jan Beulich , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org On Mon, Jul 27, 2015 at 11:26:36PM +0000, Sahita, Ravi wrote: [...] > >> This makes me think it doesn't matter if I do "xl destroy" or just > >> normal shutdown. And another test to normally shutdown guest confirmed > >> that. > >> > >> The machine I have is quite old and doesn't support EPT. The real > >> issues seems to be that you failed to properly disable that feature > >> for old machines. > > > >The altp2m feature is designed (and implemented) to be emulated on > >systems lacking hardware capabilities. > > > >As such, teardown is necessary even on older systems, but I would agree that > >there appears to be a bug. > > Yes - > the check for hvm_altp2m_supported() before altp2m_vcpu_destroy() was missing - will send a patch tonight. > Hi Ravi Any update on this? This is a blocker for the release. Please fix it as soon as possible. Wei. > Ravi > > > > > >~Andrew