From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKUAn-0000MU-26 for qemu-devel@nongnu.org; Wed, 29 Jul 2015 12:25:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKUAi-0008Qc-4H for qemu-devel@nongnu.org; Wed, 29 Jul 2015 12:25:41 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:59013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKUAh-0008Pg-Ct for qemu-devel@nongnu.org; Wed, 29 Jul 2015 12:25:36 -0400 Date: Wed, 29 Jul 2015 18:25:21 +0200 From: Aurelien Jarno Message-ID: <20150729162521.GA1655@aurel32.net> References: <1437755447-10537-1-git-send-email-aurelien@aurel32.net> <1437755447-10537-4-git-send-email-aurelien@aurel32.net> <87lhdzlzbq.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <87lhdzlzbq.fsf@linaro.org> Subject: Re: [Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy status separately List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?iso-8859-15?Q?Benn=E9e?= Cc: qemu-devel@nongnu.org, Richard Henderson On 2015-07-29 17:10, Alex Benn=E9e wrote: >=20 > Aurelien Jarno writes: >=20 > > Use two bools to track constants and copies instead of an enum. >=20 > More of an explanation would be useful as to why, otherwise it seems to > me we are just increasing the size of the structure (assuming the > compiler uses the same base sizes for the bool and enum). The reason is in the following patch, to allow separate tracking of const and copy. Note that this doesn't increase the structure size due to alignment and that the v2 of this patchset actually uses only one bool. I'll add a note about why it is need for v3. --=20 Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net