Re: [PATCH RFC V7 0/7] per event callgraph and time support

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Wed, Jul 29, 2015 at 05:42:09AM -0400, Kan Liang escreveu:
> This patchkit adds the ability to turn off callgraphs and time stamps
> per event. This in term can reduce sampling overhead and the size of
> the perf.data.

Applied the first three patches, will wait for Jiri comments on the
remaining.

- Arnaldo
 
> Changes since V1:
>   - Break up V1 patches into three patches(parse option changes,
>     partial time support and partial callgraph support).
>   - Use strings 'fp,dwarf,lbr,no' to identify callchains
>   - Add test case in parse-events.c
> 
> Changes since V2:
>   - Rebase on 60cd37eb10
> 
> Changes since V3:
>   - Replace OPT_CALLBACK_SET by current existing callback mechanism.
>   - Using perf_evsel__set_sample_bit if possible
>   - Change the expression "partial" to "per event"
>   - Using global variable to indicate if 'time' is set per event.
>     If 'time' is not set, enable it by default for perf record.
> 
> Changes since V4:
>   - Fix issue of setting callgraph_set
> 
> Changes since V5:
>   - per-event settings over global settings in general
>   - support for event post configuration structure
> 
> Changes since V6:
>   - Add error infor for per-event time
>   - rename the option to call-graph and stacl-size
>   - refine parse/config callchain functions,
>     and reuse them for per-event callgraph setting
>   - Modify perf test
> 
> Jiri Olsa (2):
>   perf tools: Add support for event post configuration
>   perf tools: Force period term to overload global settings
> 
> Kan Liang (5):
>   perf,tools: introduce callgraph_set for callgraph option
>   perf,tools: per-event time support
>   perf,tools: refine parse/config callchain functions
>   perf,tools: per-event callgraph support
>   perf,tests: Add tests to callgraph and time parse
> 
>  tools/perf/Documentation/perf-record.txt |  10 ++-
>  tools/perf/builtin-record.c              |  11 +++-
>  tools/perf/perf.h                        |   1 +
>  tools/perf/tests/parse-events.c          |  50 ++++++++++++++-
>  tools/perf/util/callchain.c              |  14 ++---
>  tools/perf/util/callchain.h              |   2 +-
>  tools/perf/util/evsel.c                  | 105 +++++++++++++++++++++++++++++--
>  tools/perf/util/evsel.h                  |  26 ++++++++
>  tools/perf/util/parse-events.c           |  94 +++++++++++++++++++++++----
>  tools/perf/util/parse-events.h           |   3 +
>  tools/perf/util/parse-events.l           |   3 +
>  tools/perf/util/pmu.c                    |   3 +-
>  12 files changed, 289 insertions(+), 33 deletions(-)
> 
> -- 
> 1.8.3.1