From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached Date: Wed, 29 Jul 2015 21:39:12 -0400 Message-ID: <20150730013912.GA4068@thunk.org> References: <20150730004937.GA3133@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150730004937.GA3133@thunk.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdWwgMjksIDIwMTUgYXQgMDg6NDk6MzdQTSAtMDQwMCwgVGhlb2RvcmUgVHMnbyB3 cm90ZToKPiAKPiBVbmZvcnR1bmF0ZWx5IHRoZSBmYWlsdXJlIGNhdXNlcyBhIHNlcmllcyBvZiBy ZWN1cnNpdmUgZmF1bHRzIGFuZCBJCj4gaGF2ZW4ndCBiZWVuIGFibGUgdG8gY2FwdHVyZSB0aGUg c3RhY2sgdHJhY2UsIGJ1dCBvbiA0LjItcmNYIGtlcm5lbHMsCj4gSSBjYW4gcmVsaWFibHkgY2F1 c2UgdGhlIHN5c3RlbSB0byBjcmFzaCBpZiBteSBUNTQwcCBpcyBib290ZWQgd2l0aAo+IHRoZSBk b2NraW5nIHN0YXRpb24gYXR0YWNoZWQuCj4gCj4gSXQgd2lsbCBhbHNvIGNyYXNoIGlmIEkgYm9v dCB0aGUgc3lzdGVtIGZpcnN0LCBhbmQgdGhlbiBpbnNlcnQgdGhlCj4gbGFwdG9wIGludG8gdGhl IGRvY2tzdGF0aW9uLgo+IAo+IFVuZm9ydHVuYXRlbHksIEkgY2FuJ3QgZ2V0IGEgc3RhY2sgdHJh Y2UgYmVjYXVzZSB0aGVyZSBhcmUgYSBodWdlCj4gbnVtYmVyIG9mIHJlY3Vyc2l2ZS9kb3VibGUg ZmF1bHRzLCBhbmQgdGhlIHN5c3RlbSBkaWVzIHNvIHF1aWNrbHkgdGhhdAo+IG5vdGhpbmcgZW5k cyB1cCBpbiB0aGUgbG9nIGZpbGVzLiAgSWYgeW91IHJlYWxseSBuZWVkIGEgc3RhY2sgZHVtcCBJ Cj4gY2FuIHRyeSB0byByaWcgc29tZXRoaW5nLCBidXQgbW9kZXJuIExhcHRvcHMgZG9uJ3QgaGF2 ZSBzZXJpYWwKPiBjb25zb2xlcyBhbnkgbW9yZSwgYWxhcywgc28gaXQncyBiaXQgb2YgYSBwYWlu LgoKVGhlIGJhZCBuZXdzIGlzIHRoYXQgSSB0cmllZCB0byB1c2Uga2R1bXAgdG8gY2FwdHVyZSBh IGNyYXNoZHVtcCBhbmQKaG9wZWZ1bGx5IGdldCBtb3JlIGluZm9ybWF0aW9uLCBhbmQga2R1bXAg dXR0ZXJseSB3ZWRnZWQgb24gdGhlIHBhbmljLgpUaGUgZ29vZCBuZXdzIGlzIGJlY2F1c2UgaXQg d2VkZ2VkIHRoZSBzeXN0ZW0sIEkgd2FzIGFibGUgdG8gZ2V0IHRoZQpjb25zb2xlIHN0YWNrZHVt cCBiZWZvcmUgaXQgc2Nyb2xsZWQgb2ZmIGR1ZSB0byBhIHdob2xlIHNlcmllcyBvZgpyZWN1cnNp dmUgb29wcyBtZXNzYWdlcy4KCkl0J3MgaGVyZTogIGh0dHBzOi8vZ29vLmdsL3Bob3Rvcy94SGpu Mlo5N0pRRXc2azJDOQoKSG9wZWZ1bGx5IHRpaHMgaXMgdXNlZnVsLiAgSXQncyBub3Qgb2J2aW91 cyBob3cgdG8gcmV2ZXJ0IHRoaXMgY2hhbmdlLApzaW5jZSB0aGVyZSB3ZXJlIGEgbGFyZ2UgbnVt YmVyIG9mIGNoYW5nZXMgdG8gaTkxNSBhZnRlciB0aGlzLiAgSWYKc29tZW9uZSBjb3VsZCBoZWxw IG1lIHdpdGggYSByZXZlcnQsIEknZCBiZSBoYXBweSB0byB0ZXN0IGl0LgoKVGhhbmtzLAoKCQkJ CQkJLSBUZWQKCQkJCQkJCgoKPiAKPiBJIHdhcyBhYmxlIHRvIGJpc2VjdCBpdCBkb3duIHRvIHRo aXMgY29tbWl0LCBob3dldmVyOiA4YzdiNWNjYjcyOTg3Ogo+ICJkcm0vaTkxNTogVXNlIGF0b21p YyBoZWxwZXJzIGZvciBjb21wdXRpbmcgY2hhbmdlZCBmbGFnczoiCj4gCj4gSXMgdGhlcmUgYW55 IGNoYW5jZSBJbnRlbCBjb3VsZCBhZGQgYSBMZW5vdm8gRG9ja3N0YXRpb24gd2l0aCBhCj4gTXVs dGlzdHJlYW0gRFAgb3V0cHV0IHRvIHBhcnQgb2YgeW91ciB0ZXN0IGhhcmR3YXJlPyAgVW5mb3J0 dW5hdGVseSBpdAo+IHNlZW1zIHByZXR0eSBjb21tb24gdGhhdCBJIHNlZSByZWdyZXNzaW9ucyB3 aXRoIG15IHBhcnRpY3VsYXIKPiBoYXJkd2FyZS4gIE1heWJlIHRoZXJlIGFyZW4ndCBlbm91Z2gg cGVvcGxlIHVzaW5nIFRoaW5rcGFkcyBhbnkgbW9yZT8gIDotKAo+IAo+ICAgICAgIAkgICAgIAkg ICAgCSAgIAkgCSAgICAgICAJICAgICAgLSBUZWQKPiAKPiAKPiBQLlMuICBUaGUgZ2l0IGJpc2Vj dCBsb2cKPiAKPiBnaXQgYmlzZWN0IHN0YXJ0Cj4gIyBiYWQ6IFs0MjFkMTI1YzA2YzRiZTRjNTAw NWNiNjk4NDAyMDZiZDA5YjcxZGQ2XSBidWlsZGRlYjogc2lnbiB0aGUgbW9kdWxlcyBhZnRlciBz cGxpdHRpbmcgb3V0IHRoZSBkZWJ1Z2luZm8gZmlsZXMKPiBnaXQgYmlzZWN0IGJhZCA0MjFkMTI1 YzA2YzRiZTRjNTAwNWNiNjk4NDAyMDZiZDA5YjcxZGQ2Cj4gIyBnb29kOiBbYjk1M2MwZDIzNGJj NzJlODQ4OWQzYmY1MWEyNzZjNWM0ZWM4NTM0NV0gTGludXggNC4xCj4gZ2l0IGJpc2VjdCBnb29k IGI5NTNjMGQyMzRiYzcyZTg0ODlkM2JmNTFhMjc2YzVjNGVjODUzNDUKPiAjIGdvb2Q6IFthZWFh MjEyMmFmNGU1M2YzYmZkMjhlOGYyOTQ1NTdiYjk1YWY0M2ZjXSBkcm0vaTkxNS9za2w6IEFkZCB0 aGUgSU5JVCBwb3dlciBkb21haW4gdG8gdGhlIE1JU0MgSS9PIHBvd2VyIHdlbGwKPiBnaXQgYmlz ZWN0IGdvb2QgYWVhYTIxMjJhZjRlNTNmM2JmZDI4ZThmMjk0NTU3YmI5NWFmNDNmYwo+ICMgYmFk OiBbNGQ3MGYzOGE3NjBhZDI4NzlkMmViZDg0MDAxYzkyOTgwMTgwZjYzMF0gZHJtL2k5MTUvYmlv czogcmVtb3ZlIGEgcmVkdW5kYW50IE5VTEwgcG9pbnRlciBjaGVjawo+IGdpdCBiaXNlY3QgYmFk IDRkNzBmMzhhNzYwYWQyODc5ZDJlYmQ4NDAwMWM5Mjk4MDE4MGY2MzAKPiAjIGJhZDogWzI3YTFi Njg4ZDlmMWZhMmFiZDE0YmZlNmE4NzI5YTE5ZmIzYjFiMjVdIGRybS9pOTE1L2J4dDogRW5hYmxl IFdhRW5hYmxlWVYxMkJ1Z0ZpeEluSGFsZlNsaWNlQ2hpY2tlbjcgZm9yIEJyb3h0b24KPiBnaXQg YmlzZWN0IGJhZCAyN2ExYjY4OGQ5ZjFmYTJhYmQxNGJmZTZhODcyOWExOWZiM2IxYjI1Cj4gIyBn b29kOiBbNGJlMDczMTc4NmRlMTBkMGU5YWUxZDE1OTUwNGM4M2M2YjA1MjY0N10gZHJtL2k5MTU6 IEFkZCBjcnRjIHN0YXRlcyBiZWZvcmUgY2FsbGluZyBjb21wdXRlX2NvbmZpZygpCj4gZ2l0IGJp c2VjdCBnb29kIDRiZTA3MzE3ODZkZTEwZDBlOWFlMWQxNTk1MDRjODNjNmIwNTI2NDcKPiAjIGdv b2Q6IFtkNTQzMmE5ZDE5YjYxYmE2YTJiM2Q4OGYzMDI2ZTBjYTYwZWI1N2ExXSBkcm0vaTkxNTog U3RhZ2UgbmV3IG1vZGVzZXQgc3RhdGUgc3RyYWlnaHQgaW50byBhdG9taWMgc3RhdGUKPiBnaXQg YmlzZWN0IGdvb2QgZDU0MzJhOWQxOWI2MWJhNmEyYjNkODhmMzAyNmUwY2E2MGViNTdhMQo+ICMg YmFkOiBbYTgyMWZjNDZiYzdiYjZkNGNmOWE1ZjhkMjc4N2ZkNzAyMzFjMmMxMF0gZHJtL2k5MTU6 IFN3YXAgYXRvbWljIHN0YXRlIGluIGxlZ2FjeSBtb2Rlc2V0Cj4gZ2l0IGJpc2VjdCBiYWQgYTgy MWZjNDZiYzdiYjZkNGNmOWE1ZjhkMjc4N2ZkNzAyMzFjMmMxMAo+ICMgYmFkOiBbOGM3YjVjY2I3 Mjk4NzBlNjA2MzIxYjM3MDNlMmMyZTY5OGM0OWE5NV0gZHJtL2k5MTU6IFVzZSBhdG9taWMgaGVs cGVycyBmb3IgY29tcHV0aW5nIGNoYW5nZWQgZmxhZ3MKPiBnaXQgYmlzZWN0IGJhZCA4YzdiNWNj YjcyOTg3MGU2MDYzMjFiMzcwM2UyYzJlNjk4YzQ5YTk1Cj4gIyBnb29kOiBbMGY2M2NjYTJhZmRj Mzg4NzdlODZhY2ZhOTgyMTAyMGY2ZTIyMTNmZF0gZHJtL2k5MTU6IFVwZGF0ZSBjcnRjIHN0YXRl IGFjdGl2ZSBmbGFnIGJhc2VkIG9uIERQTVMKPiBnaXQgYmlzZWN0IGdvb2QgMGY2M2NjYTJhZmRj Mzg4NzdlODZhY2ZhOTgyMTAyMGY2ZTIyMTNmZAo+ICMgZ29vZDogWzg0MGJmZTk1MzM4NGExMzRj ODYzOWYyOTY0ZDliNzRiZmE2NzFlMTZdIGRybS9hdG9taWM6IE1ha2UgbW9kZV9maXh1cCgpIG9w dGlvbmFsIGZvciBjaGVja19tb2Rlc2V0KCkKPiBnaXQgYmlzZWN0IGdvb2QgODQwYmZlOTUzMzg0 YTEzNGM4NjM5ZjI5NjRkOWI3NGJmYTY3MWUxNgo+ICMgZmlyc3QgYmFkIGNvbW1pdDogWzhjN2I1 Y2NiNzI5ODcwZTYwNjMyMWIzNzAzZTJjMmU2OThjNDlhOTVdIGRybS9pOTE1OiBVc2UgYXRvbWlj IGhlbHBlcnMgZm9yIGNvbXB1dGluZyBjaGFuZ2VkIGZsYWdzCj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754759AbbG3BjS (ORCPT ); Wed, 29 Jul 2015 21:39:18 -0400 Received: from imap.thunk.org ([74.207.234.97]:52936 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754735AbbG3BjR (ORCPT ); Wed, 29 Jul 2015 21:39:17 -0400 Date: Wed, 29 Jul 2015 21:39:12 -0400 From: "Theodore Ts'o" To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org Subject: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached Message-ID: <20150730013912.GA4068@thunk.org> Mail-Followup-To: Theodore Ts'o , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org References: <20150730004937.GA3133@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150730004937.GA3133@thunk.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2015 at 08:49:37PM -0400, Theodore Ts'o wrote: > > Unfortunately the failure causes a series of recursive faults and I > haven't been able to capture the stack trace, but on 4.2-rcX kernels, > I can reliably cause the system to crash if my T540p is booted with > the docking station attached. > > It will also crash if I boot the system first, and then insert the > laptop into the dockstation. > > Unfortunately, I can't get a stack trace because there are a huge > number of recursive/double faults, and the system dies so quickly that > nothing ends up in the log files. If you really need a stack dump I > can try to rig something, but modern Laptops don't have serial > consoles any more, alas, so it's bit of a pain. The bad news is that I tried to use kdump to capture a crashdump and hopefully get more information, and kdump utterly wedged on the panic. The good news is because it wedged the system, I was able to get the console stackdump before it scrolled off due to a whole series of recursive oops messages. It's here: https://goo.gl/photos/xHjn2Z97JQEw6k2C9 Hopefully tihs is useful. It's not obvious how to revert this change, since there were a large number of changes to i915 after this. If someone could help me with a revert, I'd be happy to test it. Thanks, - Ted > > I was able to bisect it down to this commit, however: 8c7b5ccb72987: > "drm/i915: Use atomic helpers for computing changed flags:" > > Is there any chance Intel could add a Lenovo Dockstation with a > Multistream DP output to part of your test hardware? Unfortunately it > seems pretty common that I see regressions with my particular > hardware. Maybe there aren't enough people using Thinkpads any more? :-( > > - Ted > > > P.S. The git bisect log > > git bisect start > # bad: [421d125c06c4be4c5005cb69840206bd09b71dd6] builddeb: sign the modules after splitting out the debuginfo files > git bisect bad 421d125c06c4be4c5005cb69840206bd09b71dd6 > # good: [b953c0d234bc72e8489d3bf51a276c5c4ec85345] Linux 4.1 > git bisect good b953c0d234bc72e8489d3bf51a276c5c4ec85345 > # good: [aeaa2122af4e53f3bfd28e8f294557bb95af43fc] drm/i915/skl: Add the INIT power domain to the MISC I/O power well > git bisect good aeaa2122af4e53f3bfd28e8f294557bb95af43fc > # bad: [4d70f38a760ad2879d2ebd84001c92980180f630] drm/i915/bios: remove a redundant NULL pointer check > git bisect bad 4d70f38a760ad2879d2ebd84001c92980180f630 > # bad: [27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25] drm/i915/bxt: Enable WaEnableYV12BugFixInHalfSliceChicken7 for Broxton > git bisect bad 27a1b688d9f1fa2abd14bfe6a8729a19fb3b1b25 > # good: [4be0731786de10d0e9ae1d159504c83c6b052647] drm/i915: Add crtc states before calling compute_config() > git bisect good 4be0731786de10d0e9ae1d159504c83c6b052647 > # good: [d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1] drm/i915: Stage new modeset state straight into atomic state > git bisect good d5432a9d19b61ba6a2b3d88f3026e0ca60eb57a1 > # bad: [a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10] drm/i915: Swap atomic state in legacy modeset > git bisect bad a821fc46bc7bb6d4cf9a5f8d2787fd70231c2c10 > # bad: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags > git bisect bad 8c7b5ccb729870e606321b3703e2c2e698c49a95 > # good: [0f63cca2afdc38877e86acfa9821020f6e2213fd] drm/i915: Update crtc state active flag based on DPMS > git bisect good 0f63cca2afdc38877e86acfa9821020f6e2213fd > # good: [840bfe953384a134c8639f2964d9b74bfa671e16] drm/atomic: Make mode_fixup() optional for check_modeset() > git bisect good 840bfe953384a134c8639f2964d9b74bfa671e16 > # first bad commit: [8c7b5ccb729870e606321b3703e2c2e698c49a95] drm/i915: Use atomic helpers for computing changed flags >