From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755122AbbG3JHx (ORCPT ); Thu, 30 Jul 2015 05:07:53 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35996 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754800AbbG3JHv (ORCPT ); Thu, 30 Jul 2015 05:07:51 -0400 Date: Thu, 30 Jul 2015 10:07:47 +0100 From: Matt Fleming To: Jiang Liu Cc: Thomas Gleixner , Ingo Molnar , Chen Yu , "H. Peter Anvin" , x86@kernel.org, Yinghai Lu , Tony Luck , linux-kernel@vger.kernel.org Subject: Re: [Bugfix] x86, irq: Fix regression caused by commit d32932d02e18 Message-ID: <20150730090747.GA2704@codeblueprint.co.uk> References: <1438242695-23531-1-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438242695-23531-1-git-send-email-jiang.liu@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jul, at 03:51:32PM, Jiang Liu wrote: > Commit d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical > irqdomain interfaces") introduced a regression when converting IOAPIC > to hierarchy irqdomain, which sets wrong irq flow handler for IOAPIC > pins on Surface Pro 3 and causes failure when detecting I2C controllers. > It's caused by using stale attribute value when setting up IOAPIC pins. > With this patch applied, all IOAPIC IRQ configuration are identical > to v4.1 on Surface Pro 3. > > Fixes: d32932d02e18 ("x86/irq: Convert IOAPIC to use hierarchical irqdomain interfaces") > Reported-by: Matt Fleming > Tested-and-reported-by: Chen Yu > Signed-off-by: Jiang Liu > --- > Hi Matt, > Could you please help to test this patch? > Thanks! > Gerry > --- > arch/x86/kernel/apic/io_apic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Works for me! What I actually did was apply this fixup commit ontop of commit d32932d02e18, just to be sure that it fixes the issue. I'm about to apply it on top of -rc4 just to be sure. But failing any issues arising, Tested-by: Matt Fleming -- Matt Fleming, Intel Open Source Technology Center