Re: [PATCH 3/4] mtd: nand: nand_get_flash_type: Print detected ECC strength and size

[Boris Brezillon <boris.brezillon@free-electrons.com>]

Hi Hans,

On Wed, 29 Jul 2015 19:53:53 +0200
Hans de Goede <hdegoede@redhat.com> wrote:

> Print the detected ECC strength and size from nand_get_flash_type().

Indeed, that's an interesting information.

> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/mtd/nand/nand_base.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index f3fefbf..e2e2690 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -4433,9 +4433,10 @@ ident_done:
>  		pr_info("%s %s\n", nand_manuf_ids[maf_idx].name,
>  				type->name);
>  
> -	pr_info("%d MiB, %s, erase size: %d KiB, page size: %d, OOB size: %d\n",
> +	pr_info("%d MiB, %s, erase size: %d KiB, page size: %d, OOB size: %d, ECC strength %d size %d\n",

How about the follwing formalism ?

	pr_info("%d MiB, type: %s, erase size: %d KiB, page size: %d, OOB size: %d, ECC: %dbits/%dbytes\n",

or just

	pr_info("%d MiB, type: %s, erase size: %d KiB, page size: %d, OOB size: %d, ECC: %d/%d\n",

Best Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com