From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached Date: Thu, 30 Jul 2015 11:32:28 -0400 Message-ID: <20150730153228.GA15113@thunk.org> References: <20150730004937.GA3133@thunk.org> <20150730013912.GA4068@thunk.org> <20150730144002.GY16722@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20150730144002.GY16722@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Torvalds , intel-gfx , DRI , Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMzAsIDIwMTUgYXQgMDQ6NDA6MDJQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIEp1bCAyOSwgMjAxNSBhdCAxMDoxODoxNlBNIC0wNzAwLCBMaW51cyBU b3J2YWxkcyB3cm90ZToKPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8 IDggKysrKystLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNf aGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gaW5kZXgg NWI1OWQ1YWQ3ZDFjLi5hYWMyMTIyOTdiNDkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMKPiA+IEBAIC0yMzAsMTAgKzIzMCwxMiBAQCB1cGRhdGVfY29ubmVjdG9yX3Jv dXRpbmcoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLCBpbnQgY29ubl9pZHgpCj4gPiAg CX0KPiA+ICAKPiA+ICAJY29ubmVjdG9yX3N0YXRlLT5iZXN0X2VuY29kZXIgPSBuZXdfZW5jb2Rl cjsKPiA+IC0JaWR4ID0gZHJtX2NydGNfaW5kZXgoY29ubmVjdG9yX3N0YXRlLT5jcnRjKTsKPiA+ ICsJaWYgKGNvbm5lY3Rvcl9zdGF0ZS0+Y3J0Yykgewo+ID4gKwkJaWR4ID0gZHJtX2NydGNfaW5k ZXgoY29ubmVjdG9yX3N0YXRlLT5jcnRjKTsKPiA+ICAKPiA+IC0JY3J0Y19zdGF0ZSA9IHN0YXRl LT5jcnRjX3N0YXRlc1tpZHhdOwo+ID4gLQljcnRjX3N0YXRlLT5tb2RlX2NoYW5nZWQgPSB0cnVl Owo+ID4gKwkJY3J0Y19zdGF0ZSA9IHN0YXRlLT5jcnRjX3N0YXRlc1tpZHhdOwo+ID4gKwkJY3J0 Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKPiA+ICsJfQo+IAo+IFRoaXMgc2hvdWxkbid0 IGhhcHBlbiBzaW5jZSBpZiBpdCBkb2VzIHdlIGVuZGVkIHVwIHN0ZWFsaW5nIHRoZSBlbmNvZGVy Cj4gZnJvbSB0aGUgY29ubmVjdG9yIGl0c2VsZiAod2UgZG8gY2hlY2sgZm9yIGNvbm5lY3Rvcl9z dGF0ZS0+Y3J0YyBlYXJsaWVyKQo+IGFuZCB0aGF0IHdvdWxkIGJlIGEgYnVnLiBJIGhhdmVuJ3Qg ZmlndXJlZCBvdXQgYSBwcmVjaXNlIHRoZW9yeSBidXQgbXkKPiBndWVzcyBpcyBvbiB0aGUgYmVz dF9lbmNvZGVyIHNlbGVjdGlvbiwgYW5kIGluZGVlZCBkcCBtc3QgZW5jb2Rlcgo+IHNlbGVjdGlv biBzZWVtcyB0byBoYXZlIGdvbmUgYmVsbHkgdXAgaW4gNC4yIHdpdGggdGhlIGJpc2VjdGVkIGNv bW1pdC4KCldlbGwsIEkganVzdCB0ZXN0ZWQgTGludXMncyBwYXRjaCBhbmQgaXQgd29ya3MuCgpC VFcsIGlzIHRoZXJlIGFueSBjaGFuY2UgdGhhdCBJIGNhbiBzdXNwZW5kIG15IGxhcHRvcCwgYW5k IHRoZW4gbW92ZQppdCBmcm9tIG15IGRvY2tpbmcgc3RhdGlvbiBhdCBob21lICh3aGVyZSBJIGhh dmUgYSBEZWxsIDMwIiBkaXNwbGF5KQp0byBteSBkb2NraW5nIHN0YXRpb24gYXQgd29yayAod2hl cmUgSSBoYXZlIGEgRGVsbCAyNCIgZGlzcGxheSksIGFuZAphY3R1YWxseSBoYXZlIHRoZSBuZXcg bW9uaXRvciBiZSBkZXRlY3RlZD8gIEZvciBhdCBsZWFzdCB0aGUgcGFzdAp5ZWFyLCBJIGhhdmUg dG8gcmVib290IGluIG9yZGVyIHRvIGJlIGFibGUgdG8gdXNlIHRoZSBleHRlcm5hbAptb25pdG9y PyAgVGhpcyB1c2VkIHRvIHdvcmssIGJ1dCBpdCdzIGJlZW4gYSB2ZXJ5IGxvbmctc3RhbmRpbmcK cmVncmVzc2lvbi4gIEkgdW5kcnN0YW5kIHRoYXQgTXVsdGktc3RyZWFtIERQIGlzIGEgZXZpbCBo b3JyaWJsZSBoYWNrLAphbmQgc3VwcG9ydGluZyBpdCBpcyBwYWluZnVsLCBidXQgdGhpcyB1c2Vk IHRvIHdvcmssIGFuZCBpdCBoYXNuJ3QgaW4KYSBsb25nIHRpbWUuICA6LSgKCgkJCQkJLSBUZWQK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752334AbbG3Pcg (ORCPT ); Thu, 30 Jul 2015 11:32:36 -0400 Received: from imap.thunk.org ([74.207.234.97]:59525 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbbG3Pcd (ORCPT ); Thu, 30 Jul 2015 11:32:33 -0400 Date: Thu, 30 Jul 2015 11:32:28 -0400 From: "Theodore Ts'o" To: Linus Torvalds , intel-gfx , DRI , Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , Linux Kernel Mailing List Subject: Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached Message-ID: <20150730153228.GA15113@thunk.org> Mail-Followup-To: Theodore Ts'o , Linus Torvalds , intel-gfx , DRI , Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , Linux Kernel Mailing List References: <20150730004937.GA3133@thunk.org> <20150730013912.GA4068@thunk.org> <20150730144002.GY16722@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150730144002.GY16722@phenom.ffwll.local> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: > On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: > > drivers/gpu/drm/drm_atomic_helper.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > > index 5b59d5ad7d1c..aac212297b49 100644 > > --- a/drivers/gpu/drm/drm_atomic_helper.c > > +++ b/drivers/gpu/drm/drm_atomic_helper.c > > @@ -230,10 +230,12 @@ update_connector_routing(struct drm_atomic_state *state, int conn_idx) > > } > > > > connector_state->best_encoder = new_encoder; > > - idx = drm_crtc_index(connector_state->crtc); > > + if (connector_state->crtc) { > > + idx = drm_crtc_index(connector_state->crtc); > > > > - crtc_state = state->crtc_states[idx]; > > - crtc_state->mode_changed = true; > > + crtc_state = state->crtc_states[idx]; > > + crtc_state->mode_changed = true; > > + } > > This shouldn't happen since if it does we ended up stealing the encoder > from the connector itself (we do check for connector_state->crtc earlier) > and that would be a bug. I haven't figured out a precise theory but my > guess is on the best_encoder selection, and indeed dp mst encoder > selection seems to have gone belly up in 4.2 with the bisected commit. Well, I just tested Linus's patch and it works. BTW, is there any chance that I can suspend my laptop, and then move it from my docking station at home (where I have a Dell 30" display) to my docking station at work (where I have a Dell 24" display), and actually have the new monitor be detected? For at least the past year, I have to reboot in order to be able to use the external monitor? This used to work, but it's been a very long-standing regression. I undrstand that Multi-stream DP is a evil horrible hack, and supporting it is painful, but this used to work, and it hasn't in a long time. :-( - Ted