From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Potential lost receive WCs (was "[PATCH WIP 38/43]")
Date: Thu, 30 Jul 2015 10:00:13 -0600 [thread overview]
Message-ID: <20150730160013.GA16659@obsidianresearch.com> (raw)
In-Reply-To: <55B9CB78.9040501-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Thu, Jul 30, 2015 at 10:00:08AM +0300, Sagi Grimberg wrote:
> I still think that draining the CQ without respecting a quota is
> wrong, even if driverX has a glitch there.
Sure, but you can't just return from the CQ upcall after doing a
budget and expect to be called again in the future. That is absolutely
wrong.
It is very difficult to mix and match processing in the CQ upcall and
in another context.
So, either you drain the whole thing in the CQ upcall, or delegate to
another context and process it there, possibly sleeping during
processing when the budget is hit.
Overall, the process is the same, drain entirely before calling
ib_req_notify_cq, don't expect any CQ upcalls until ib_req_notify_cq
is called.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-07-30 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 20:26 Potential lost receive WCs (was "[PATCH WIP 38/43]") Chuck Lever
[not found] ` <7824831C-3CC5-49C4-9E0B-58129D0E7FFF-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-24 20:46 ` Jason Gunthorpe
[not found] ` <20150724204604.GA28244-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-07-29 20:47 ` Chuck Lever
[not found] ` <E855E210-F640-4104-9B35-2A75DF1BF2E3-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-29 21:15 ` Jason Gunthorpe
[not found] ` <20150729211557.GA16284-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-07-29 21:19 ` Chuck Lever
[not found] ` <DC5354A4-3EB4-46FF-AA34-9AE26DD25031-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-30 7:00 ` Sagi Grimberg
[not found] ` <55B9CB78.9040501-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-07-30 14:51 ` Chuck Lever
2015-07-30 16:00 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730160013.GA16659@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.