From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] usb: lpc32xx: add host USB driver
Date: Thu, 30 Jul 2015 16:20:15 +0200 [thread overview]
Message-ID: <201507301620.15693.marex@denx.de> (raw)
In-Reply-To: <4F172219764C784B84C2C1FF44E7DFB103004473@003FCH1MPN2-041.003f.mgd2.msft.net>
On Thursday, July 30, 2015 at 04:13:14 PM, LEMIEUX, SYLVAIN wrote:
> Hi Marek,
Hi!
> Thanks for the feedback. I will do the change and submit a new revision of
> the patch.
>
> For your question regarding reference to UART 5 inside the USB driver;
> * It is possible to also route the UART5 Tx/Rx pin to the USB D+ and D-
> pins; the driver ensure this is not selected.
> For details, refer to UM10326, "LPC32x0 and LPC32x0/01 User manual -
> Rev. 3" table 459 and paragraph 17.2.3.2.6.
> * I will add comments in the code.
Well in that case, you should pull out a separate pinmux code and do the
pinmuxing in the board setup code, definitelly not in the USB driver.
Best regards,
Marek Vasut
prev parent reply other threads:[~2015-07-30 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 16:14 [U-Boot] [PATCH v2 4/4] usb: lpc32xx: add host USB driver slemieux.tyco at gmail.com
2015-07-29 23:33 ` Marek Vasut
2015-07-30 14:13 ` LEMIEUX, SYLVAIN
2015-07-30 14:20 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201507301620.15693.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.