From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Rutherford Subject: Re: [PATCH v7 1/4] KVM: x86: Split the APIC from the rest of IRQCHIP. Date: Thu, 30 Jul 2015 14:19:25 -0700 Message-ID: <20150730211925.GA28478@google.com> References: <1438237303-19124-1-git-send-email-srutherford@google.com> <55B9DEA2.1070304@redhat.com> <20150730083739.GB19524@google.com> <55B9F08C.6080604@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Paolo Bonzini , Jan Kiszka Return-path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:34644 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbbG3VTf (ORCPT ); Thu, 30 Jul 2015 17:19:35 -0400 Received: by pacan13 with SMTP id an13so29669965pac.1 for ; Thu, 30 Jul 2015 14:19:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55B9F08C.6080604@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jul 30, 2015 at 11:38:20AM +0200, Paolo Bonzini wrote: > > > On 30/07/2015 10:37, Steve Rutherford wrote: > > This looks a bit non-sensical, but is overprepared for the introduction > > IOAPIC hotplug, which two patches down the line. Changing it is fine, > > you'll just need to merge the very same change back. > > By "IOAPIC hotplug" you mean changing the number of reserved routes? Is > it necessary? You could just reserve a bunch of routes depending on the > maximum number of IOAPICs. Hmm. Yeah, I think that might be cleaner. Thinking about it, I'm a bit nervous about the idea of the number of reserved routes shrinking. We would have needed to trigger an IOAPIC scan if the number of reserved routes changed. Jan might have an opinion here. > > And especially, is it documented? :) The docs say "Fails [...] if the > irqchip is already in the kernel (i.e. KVM_CREATE_IRQCHIP has already > been called)". The documentation was out of date D: > > As before, no need to resend patches for now. Let's finish discussing > all pending points, then I'll push what I have to kvm.git and you can > test it with your VMM. There should be time between this week and the next. > > Paolo