All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Cho <tony.cho@atmel.com>
Cc: devel@driverdev.osuosl.org, rachel.kim@atmel.com,
	chris.park@atmel.com, austin.shin@atmel.com,
	linux-wireless@vger.kernel.org, johnny.kim@atmel.com,
	Nicolas.FERRE@atmel.com, robin.hwang@atmel.com,
	jude.lee@atmel.com, leo.kim@atmel.com
Subject: Re: [PATCH 0/5] 2nd patch for illegal coding style
Date: Thu, 30 Jul 2015 20:49:02 -0700	[thread overview]
Message-ID: <20150731034902.GB8945@kroah.com> (raw)
In-Reply-To: <1438247414-19708-1-git-send-email-tony.cho@atmel.com>

On Thu, Jul 30, 2015 at 06:10:09PM +0900, Tony Cho wrote:
> This patch V2 includes only patches rejected. The rejected patch for the
> following, #ifdef conditionals cover entire functions, introduced new error on
> required space before the open parenthesis '('. This is my mistake while
> rewriting codes.
> 
> The original 13th patch didn't include new fix introduced on the previous patch
> due to no sync-up issue. The original 13th patch fixed the same warnings but
> in different place. 
> 
> The 64bit compile warnings will be resolved after sending these patches. Then,
> ambiguous sdio/spi parts including preprocessor conditionals will be tried.

Again, please fix the build warnings first, they are much more important
than coding style issues.

thanks,

greg k-h

      parent reply	other threads:[~2015-07-31  3:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  9:10 [PATCH 0/5] 2nd patch for illegal coding style Tony Cho
2015-07-30  9:10 ` [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions Tony Cho
2015-07-30  9:19   ` Johnny Kim
2015-07-30 11:56   ` Sudip Mukherjee
     [not found]     ` <55BAEB08.8090705@atmel.com>
2015-07-31  3:48       ` Greg KH
2015-07-30  9:10 ` [PATCH V2 2/5] staging: wilc1000: remove unnecessary blank lines Tony Cho
2015-07-30  9:10 ` [PATCH V2 3/5] staging: wilc1000: remove warnings on missing blank line Tony Cho
2015-07-30 12:10   ` Sudip Mukherjee
2015-07-30  9:10 ` [PATCH V2 4/5] staging: wilc1000: remove errors on required space Tony Cho
2015-07-30  9:10 ` [PATCH V2 5/5] staging: wilc1000: remove unused functions Tony Cho
2015-07-31  3:49 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150731034902.GB8945@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Nicolas.FERRE@atmel.com \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=johnny.kim@atmel.com \
    --cc=jude.lee@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    --cc=robin.hwang@atmel.com \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.