From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Subject: Re: [PATCH 6/8] ARM: dts: axp209: Add usb_power_supply child node to the ax209 node Date: Fri, 31 Jul 2015 07:51:04 +0200 Message-ID: <20150731075104.48c467e6@pluto.restena.lu> References: <1433885881-19809-1-git-send-email-hdegoede@redhat.com> <1433885881-19809-7-git-send-email-hdegoede@redhat.com> Reply-To: bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Hans De Goede , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Kishon Vijay Abraham I , Felipe Balbi , Maxime Ripard , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel , devicetree , linux-sunxi List-Id: linux-pm@vger.kernel.org Hi ChenYu, On Fri, 31 Jul 2015 13:31:53 +0800 Chen-Yu Tsai wrote: > Hi Hans, > > On Wed, Jun 10, 2015 at 5:37 AM, Hans de Goede wrote: > > Add a node representing the usb power supply part of the axp209 pmic, note > > that the usb power supply and the (to be added later) ac power supply will > > each have their own child-node, so that they can be separately specified > > as power-supply for other nodes using a power-supply property with a > > phandle pointing to the right axp209 child-node. > > > > Signed-off-by: Hans de Goede > > --- > > arch/arm/boot/dts/axp209.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi > > index 24c935c..051ab3b 100644 > > --- a/arch/arm/boot/dts/axp209.dtsi > > +++ b/arch/arm/boot/dts/axp209.dtsi > > @@ -89,4 +89,9 @@ > > regulator-name = "ldo5"; > > }; > > }; > > + > > + usb_power_supply: usb_power_supply { > > + compatible = "x-powers,axp202-usb-power-supply"; > > + status = "disabled"; > > Is there any reason to have this disabled by default? > AFAIK this is not something configurable in hardware, > and the driver just gives readouts and status updates. There are some devices that only have 'AC-IN' instead of usb/otg power (set-top boxes) so having the devices tell what power sources they have makes sense (otherwise those that have ac-in instead of otg would have to disable usb_power_supply) and avoids confusion by explicitly stating presence in device dts. NB: I should hopefully get my battery supply driver ported this WE, ac-in/rtc are done, this WE. I'm going to default-off for them as well (note that for some extra details should be provided in dts). Bruno > ChenYu > > > + }; > > }; > > -- > > 2.3.6 From mboxrd@z Thu Jan 1 00:00:00 1970 From: bonbons@linux-vserver.org (Bruno =?UTF-8?B?UHLDqW1vbnQ=?=) Date: Fri, 31 Jul 2015 07:51:04 +0200 Subject: [linux-sunxi] [PATCH 6/8] ARM: dts: axp209: Add usb_power_supply child node to the ax209 node In-Reply-To: References: <1433885881-19809-1-git-send-email-hdegoede@redhat.com> <1433885881-19809-7-git-send-email-hdegoede@redhat.com> Message-ID: <20150731075104.48c467e6@pluto.restena.lu> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi ChenYu, On Fri, 31 Jul 2015 13:31:53 +0800 Chen-Yu Tsai wrote: > Hi Hans, > > On Wed, Jun 10, 2015 at 5:37 AM, Hans de Goede wrote: > > Add a node representing the usb power supply part of the axp209 pmic, note > > that the usb power supply and the (to be added later) ac power supply will > > each have their own child-node, so that they can be separately specified > > as power-supply for other nodes using a power-supply property with a > > phandle pointing to the right axp209 child-node. > > > > Signed-off-by: Hans de Goede > > --- > > arch/arm/boot/dts/axp209.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi > > index 24c935c..051ab3b 100644 > > --- a/arch/arm/boot/dts/axp209.dtsi > > +++ b/arch/arm/boot/dts/axp209.dtsi > > @@ -89,4 +89,9 @@ > > regulator-name = "ldo5"; > > }; > > }; > > + > > + usb_power_supply: usb_power_supply { > > + compatible = "x-powers,axp202-usb-power-supply"; > > + status = "disabled"; > > Is there any reason to have this disabled by default? > AFAIK this is not something configurable in hardware, > and the driver just gives readouts and status updates. There are some devices that only have 'AC-IN' instead of usb/otg power (set-top boxes) so having the devices tell what power sources they have makes sense (otherwise those that have ac-in instead of otg would have to disable usb_power_supply) and avoids confusion by explicitly stating presence in device dts. NB: I should hopefully get my battery supply driver ported this WE, ac-in/rtc are done, this WE. I'm going to default-off for them as well (note that for some extra details should be provided in dts). Bruno > ChenYu > > > + }; > > }; > > -- > > 2.3.6