From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH V3 11/7] Orangefs: large integer implicitly truncated to
 unsigned type
Date: Fri, 31 Jul 2015 09:26:55 +0100
Message-ID: <20150731082649.GU17109@ZenIV.linux.org.uk>
References: <1437143897-9069-1-git-send-email-root@logtruck.clemson.edu>
 <1438288381-12327-1-git-send-email-hubcap@logtruck.clemson.edu>
 <20150731073622.GA14506@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: hubcap <hubcap@omnibond.com>, linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:36898 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750927AbbGaI1A (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 31 Jul 2015 04:27:00 -0400
Content-Disposition: inline
In-Reply-To: <20150731073622.GA14506@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jul 31, 2015 at 12:36:22AM -0700, Christoph Hellwig wrote:
> On Thu, Jul 30, 2015 at 04:33:01PM -0400, hubcap wrote:
> > From: Mike Marshall <hubcap@omnibond.com>
> > 
> > make.cross ARCH=tile doesn't like "inode->i_bytes = PAGE_CACHE_SIZE;",
> > so cast PAGE_CACHE_SIZE to unsigned short.
> 
> I don't think this is correct.  i_bytes is short because it only
> contains the low bits of th size, the rest goes into i_blocks.
> 
> You probably want to use inode_set_bytes here instead.

... or just leave ->i_bytes zero, what with PAGE_CACHE_SIZE being a multiple
of 512...