From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 31 Jul 2015 09:33:30 +0000 Subject: [patch] drm/omap: checking for NULL instead of IS_ERR() Message-Id: <20150731093330.GA11127@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie , Archit Taneja Cc: Daniel Vetter , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabian Frederick , Tomi Valkeinen , Laurent Pinchart , Thierry Reding We recently start using the new drm_fb_helper functions but the error handling needs to be updated as well to check for IS_ERR() instead of NULL. Fixes: 377eb331375f ('drm/omap: Use new drm_fb_helper functions') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 08ef090..b8e4cde 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -180,9 +180,9 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, mutex_lock(&dev->struct_mutex); fbi = drm_fb_helper_alloc_fbi(helper); - if (!fbi) { + if (IS_ERR(fbi)) { dev_err(dev->dev, "failed to allocate fb info\n"); - ret = -ENOMEM; + ret = PTR_ERR(fbi); goto fail_unlock; } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/omap: checking for NULL instead of IS_ERR() Date: Fri, 31 Jul 2015 12:33:30 +0300 Message-ID: <20150731093330.GA11127@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id 396DE6E6BD for ; Fri, 31 Jul 2015 02:34:11 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Archit Taneja Cc: Daniel Vetter , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabian Frederick , Tomi Valkeinen , Laurent Pinchart , Thierry Reding List-Id: dri-devel@lists.freedesktop.org V2UgcmVjZW50bHkgc3RhcnQgdXNpbmcgdGhlIG5ldyBkcm1fZmJfaGVscGVyIGZ1bmN0aW9ucyBi dXQgdGhlIGVycm9yCmhhbmRsaW5nIG5lZWRzIHRvIGJlIHVwZGF0ZWQgYXMgd2VsbCB0byBjaGVj ayBmb3IgSVNfRVJSKCkgaW5zdGVhZCBvZgpOVUxMLgoKRml4ZXM6IDM3N2ViMzMxMzc1ZiAoJ2Ry bS9vbWFwOiBVc2UgbmV3IGRybV9mYl9oZWxwZXIgZnVuY3Rpb25zJykKU2lnbmVkLW9mZi1ieTog RGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZmJkZXYuYyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFw ZHJtL29tYXBfZmJkZXYuYwppbmRleCAwOGVmMDkwLi5iOGU0Y2RlIDEwMDY0NAotLS0gYS9kcml2 ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2ZiZGV2LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL29t YXBkcm0vb21hcF9mYmRldi5jCkBAIC0xODAsOSArMTgwLDkgQEAgc3RhdGljIGludCBvbWFwX2Zi ZGV2X2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAogCW11dGV4X2xvY2soJmRl di0+c3RydWN0X211dGV4KTsKIAogCWZiaSA9IGRybV9mYl9oZWxwZXJfYWxsb2NfZmJpKGhlbHBl cik7Ci0JaWYgKCFmYmkpIHsKKwlpZiAoSVNfRVJSKGZiaSkpIHsKIAkJZGV2X2VycihkZXYtPmRl diwgImZhaWxlZCB0byBhbGxvY2F0ZSBmYiBpbmZvXG4iKTsKLQkJcmV0ID0gLUVOT01FTTsKKwkJ cmV0ID0gUFRSX0VSUihmYmkpOwogCQlnb3RvIGZhaWxfdW5sb2NrOwogCX0KIApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=