From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbbGaLMz (ORCPT ); Fri, 31 Jul 2015 07:12:55 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57781 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbbGaLMy (ORCPT ); Fri, 31 Jul 2015 07:12:54 -0400 Date: Fri, 31 Jul 2015 13:12:46 +0200 From: Peter Zijlstra To: Oleg Nesterov Cc: Ingo Molnar , Rik van Riel , Tejun Heo , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] stop_machine: kill stop_cpus_lock and lg_double_lock/unlock() Message-ID: <20150731111246.GS18673@twins.programming.kicks-ass.net> References: <20150721192219.GA31150@redhat.com> <20150721192247.GA31191@redhat.com> <20150730215527.GQ25159@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150730215527.GQ25159@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2015 at 11:55:27PM +0200, Peter Zijlstra wrote: > > Exclusion between stop_{one,two}_cpu{,s}() and stop_cpus() makes this > trivially go away. > > Paul's RCU branch already kills try_stop_cpus() dead, so that wart is > also gone. But we're still stuck with stop_machine_from_inactive_cpu() > which does a spin-wait for exclusive state. So I suppose we'll have to > keep stop_cpus_mutex :/ *groan* we really need to kill that from_inactive_cpu() shite too. Lemme go have a look at how this MTRR crap works.