Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Jul 31, 2015 at 02:49:49PM +0200, Paolo Bonzini wrote:
> 
> 
> On 31/07/2015 12:17, Daniel P. Berrange wrote:
> > 
> >   CC    util/osdep.o
> > In file included from include/qemu-common.h:48:0,
> >                  from util/osdep.c:48:
> > include/sysemu/os-win32.h:77:12: error: redundant redeclaration of 'gmtime_r' [-Werror=redundant-decls]
> >  struct tm *gmtime_r(const time_t *timep, struct tm *result);
> >             ^
> > In file included from include/qemu-common.h:35:0,
> >                  from util/osdep.c:48:
> > /usr/i686-w64-mingw32/sys-root/mingw/include/time.h:272:107: note: previous definition of 'gmtime_r' was here
> > In file included from include/qemu-common.h:48:0,
> >                  from util/osdep.c:48:
> > include/sysemu/os-win32.h:79:12: error: redundant redeclaration of 'localtime_r' [-Werror=redundant-decls]
> >  struct tm *localtime_r(const time_t *timep, struct tm *result);
> >             ^
> > In file included from include/qemu-common.h:35:0,
> >                  from util/osdep.c:48:
> > /usr/i686-w64-mingw32/sys-root/mingw/include/time.h:269:107: note: previous definition of 'localtime_r' was here
> > 
> > This change adds a configure test to see if localtime_r
> > exits, and only enables the QEMU impl if missing. We also
> > re-arrange qemu-common.h try attempt to guarantee that all
> > source files get unistd.h before time.h and thus see the
> > localtime_r/gmtime_r defs.
> 
> These are only with --enable-werror, right?  The patch shouldn't be
> necessary for 2.4.

True, these are warnings only, so only fatal if you turn on Werror


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|