From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Dean Lee <dean.lee@atmel.com>, Rachel Kim <rachel.kim@atmel.com>,
Johnny Kim <johnny.kim@atmel.com>,
Chris Park <chris.park@atmel.com>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:wilc1000 :Remove typedef from struct
Date: Fri, 31 Jul 2015 13:52:13 -0700 [thread overview]
Message-ID: <20150731205213.GF1650@kroah.com> (raw)
In-Reply-To: <1438321127-8120-1-git-send-email-shraddha.6596@gmail.com>
On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: do not add new typedefs
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 54eb8a1..d6ef6e1 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -88,7 +88,7 @@ typedef enum {
> } tenuFrmSubtype;
>
> /* Basic Frame Classes */
> -typedef enum {
> +enum {
> CLASS1_FRAME_TYPE = 0x00,
> CLASS2_FRAME_TYPE = 0x01,
> CLASS3_FRAME_TYPE = 0x02,
Did you test-build this change?
next prev parent reply other threads:[~2015-07-31 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 5:38 [PATCH] Staging:wilc1000 :Remove typedef from struct Shraddha Barke
2015-07-31 20:52 ` Greg Kroah-Hartman [this message]
2015-08-01 4:55 ` Sudip Mukherjee
2015-08-01 15:55 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-07-31 5:32 [PATCH] Staging : wilc1000 " Shraddha Barke
2015-07-31 5:46 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731205213.GF1650@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.