All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Incarnation P. Lee" <incarnation.p.lee@outlook.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
	Julia.Lawall@lip6.fr, HPDD-discuss@ml01.01.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: lustre: Add blank line after variable definition.
Date: Fri, 31 Jul 2015 15:52:59 -0700	[thread overview]
Message-ID: <20150731225259.GA7705@kroah.com> (raw)
In-Reply-To: <BLU436-SMTP8916F73EBB6519D40AA31AA4800@phx.gbl>

On Sat, Jul 25, 2015 at 09:49:00AM +0800, Incarnation P. Lee wrote:
> From: "Pan Li" <incarnation.p.lee@outlook.com>
> 
> Add blank line after local variable definition to make it clear for reading.
> Signed-off-by: Pan Li <incarnation.p.lee@outlook.com>

Please put a blank line before your signed-off-by line, otherwise the
tools don't pick it up properly.

Please fix up and resend the series.

thanks,

greg k-h

  reply	other threads:[~2015-07-31 22:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <pli280>
2015-07-25  1:48 ` [PATCH 0/5] staging: lustre: cl_page.c: Fix one file coding sytle issue Incarnation P. Lee
2015-07-25  1:49 ` [PATCH 1/5] staging: lustre: Add blank line after variable definition Incarnation P. Lee
2015-07-31 22:52   ` Greg KH [this message]
2015-07-25  1:49 ` [PATCH 2/5] staging: lustre: Add one space after ',' in parameters list Incarnation P. Lee
2015-07-27  4:48   ` [PATCH 2/5] staging: lustre: Add one space after ', ' " Sudip Mukherjee
2015-07-25  1:50 ` [PATCH 3/5] staging: lustre: Remove unnecessary braces {} Incarnation P. Lee
2015-07-25  1:50 ` [PATCH 4/5] staging: lustre: Replace spaces at the start of a line Incarnation P. Lee
2015-07-25  1:51 ` [PATCH 5/5] staging: lustre: Adjust code indent for macro Incarnation P. Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150731225259.GA7705@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=incarnation.p.lee@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.