From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: akpm@linux-foundation.org, linaro-kernel@lists.linaro.org,
linux-kernel@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
"Masaki Ota" <masaki.ota@jp.alps.com>,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL)
Date: Sat, 1 Aug 2015 16:52:51 +0530 [thread overview]
Message-ID: <20150801112251.GK899@linux> (raw)
In-Reply-To: <20150731165841.GD5613@dtor-ws>
On 31-07-15, 09:58, Dmitry Torokhov wrote:
> On Fri, Jul 31, 2015 at 02:08:25PM +0530, Viresh Kumar wrote:
> > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> > is no need to do that again from its callers. Drop it.
>
> I'd rather keep it as it documents the expected behavior and double
> unlikely should work just fine.
TBH, I don't really agree that it is there for documentation. The only purpose
of such compiler flags is to try make code more efficient.
Anyway, I got to this series as someone asked me to fix this for one of my
patches which used unlikely(IS_ERR_OR_NULL()). And so I thought about fixing all
sites that are doing double unlikely (that shouldn't hurt for sure).
I will leave it to you.
--
viresh
next prev parent reply other threads:[~2015-08-01 11:22 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 8:38 [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31 8:38 ` [PATCH 01/15] err.h: add (missing) unlikely() to IS_ERR_OR_NULL() Viresh Kumar
2015-07-31 8:38 ` [PATCH 02/15] PM / OPP: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 8:38 ` [PATCH 03/15] drivers: devfreq: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 8:38 ` [PATCH 04/15] drivers: gpu: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 15:53 ` Sinclair Yeh
2015-07-31 15:53 ` Sinclair Yeh
2015-08-03 8:01 ` Daniel Vetter
2015-08-03 8:01 ` Daniel Vetter
2015-07-31 8:38 ` [PATCH 05/15] drivers: input: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 16:58 ` Dmitry Torokhov
2015-08-01 11:22 ` Viresh Kumar [this message]
2015-08-01 11:44 ` Pali Rohár
2015-08-02 15:43 ` Pavel Machek
2015-08-02 15:43 ` Pavel Machek
2015-08-02 15:59 ` Pali Rohár
2015-07-31 8:38 ` [PATCH 06/15] drivers: md: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 8:38 ` [PATCH 07/15] drivers: misc: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 08/15] drivers: net: " Viresh Kumar
2015-07-31 15:04 ` Murali Karicheri
2015-07-31 15:39 ` David Laight
2015-07-31 16:20 ` Viresh Kumar
2015-08-03 15:52 ` Murali Karicheri
2015-07-31 8:38 ` [rtc-linux] [PATCH 09/15] drivers: rtc: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 9:31 ` [rtc-linux] [PATCH] drivers: rtc: fix ptr_ret.cocci warnings Viresh Kumar
2015-07-31 9:31 ` Viresh Kumar
2015-07-31 9:31 ` Viresh Kumar
2015-08-11 15:54 ` [rtc-linux] " Alexandre Belloni
2015-08-11 15:54 ` Alexandre Belloni
2015-08-11 15:54 ` Alexandre Belloni
2015-07-31 10:53 ` [rtc-linux] [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31 10:53 ` Viresh Kumar
2015-07-31 10:53 ` Viresh Kumar
2015-08-03 4:32 ` [rtc-linux] " 'Hans Ulli Kroll' via rtc-linux
2015-08-03 4:32 ` Hans Ulli Kroll
2015-08-03 4:32 ` Hans Ulli Kroll
2015-08-11 15:54 ` [rtc-linux] " Alexandre Belloni
2015-08-11 15:54 ` Alexandre Belloni
2015-08-11 15:54 ` Alexandre Belloni
2015-07-31 8:38 ` [PATCH 10/15] drivers: staging: Drop unlikely " Viresh Kumar
2015-07-31 8:38 ` [PATCH 11/15] drivers: target: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-08-03 5:45 ` Nicholas A. Bellinger
2015-07-31 8:38 ` [PATCH 12/15] fs: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 9:20 ` David Howells
2015-07-31 9:20 ` David Howells
2015-07-31 9:20 ` David Howells
2015-07-31 8:38 ` [PATCH 13/15] blk-cgroup: " Viresh Kumar
2015-07-31 11:59 ` Tejun Heo
2015-07-31 8:38 ` [PATCH 14/15] mm: " Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 8:56 ` Kirill A. Shutemov
2015-07-31 8:56 ` Kirill A. Shutemov
2015-07-31 9:32 ` yalin wang
2015-07-31 9:32 ` yalin wang
2015-07-31 9:34 ` Viresh Kumar
2015-07-31 9:34 ` Viresh Kumar
2015-07-31 10:28 ` Joe Perches
2015-07-31 10:28 ` Joe Perches
2015-07-31 11:06 ` Viresh Kumar
2015-07-31 11:06 ` Viresh Kumar
2015-07-31 18:00 ` Joe Perches
2015-07-31 18:00 ` Joe Perches
2015-08-01 11:18 ` Viresh Kumar
2015-08-01 11:18 ` Viresh Kumar
2015-07-31 8:38 ` [PATCH 15/15] net: " Viresh Kumar
2015-07-31 8:50 ` Viresh Kumar
2015-07-31 8:38 ` Viresh Kumar
2015-07-31 9:41 ` [PATCH 00/15] trivial: " Vlastimil Babka
2015-07-31 9:49 ` Viresh Kumar
2015-07-31 10:23 ` Kirill A. Shutemov
2015-07-31 11:02 ` [PATCH] staging: lustre: drop redundant check Viresh Kumar
2015-07-31 11:04 ` [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-03 21:38 ` Steven Rostedt
2015-08-04 2:19 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801112251.GK899@linux \
--to=viresh.kumar@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.