From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751265AbbHAOr5 (ORCPT ); Sat, 1 Aug 2015 10:47:57 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56572 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbbHAOrz (ORCPT ); Sat, 1 Aug 2015 10:47:55 -0400 Date: Sat, 1 Aug 2015 07:47:52 -0700 From: Guenter Roeck To: Ulrich Obergfell Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, dzickus@redhat.com, atomlin@redhat.com, jolsa@kernel.org, mhocko@suse.cz, eranian@google.com, cmetcalf@ezchip.com, fweisbec@gmail.com Subject: Re: [PATCH 2/4] watchdog: introduce watchdog_suspend() and watchdog_resume() Message-ID: <20150801144752.GA664@roeck-us.net> References: <1438433365-2979-1-git-send-email-uobergfe@redhat.com> <1438433365-2979-3-git-send-email-uobergfe@redhat.com> <20150801140416.GA31835@roeck-us.net> <1011280917.2174199.1438439962274.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1011280917.2174199.1438439962274.JavaMail.zimbra@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 01, 2015 at 10:39:22AM -0400, Ulrich Obergfell wrote: > > ----- Original Message ----- > > From: "Guenter Roeck" > > ... > > Subject: Re: [PATCH 2/4] watchdog: introduce watchdog_suspend() and watchdog_resume() > > > > On Sat, Aug 01, 2015 at 02:49:23PM +0200, Ulrich Obergfell wrote: > >> This interface can be utilized to deactivate the hard and soft lockup > >> detector temporarily. Callers are expected to minimize the duration of > >> deactivation. Multiple deactivations are allowed to occur in parallel > >> but should be rare in practice. > >> > >> Signed-off-by: Ulrich Obergfell > >> --- > >> include/linux/nmi.h | 2 ++ > >> kernel/watchdog.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > >> 2 files changed, 67 insertions(+) > >> > >> diff --git a/include/linux/nmi.h b/include/linux/nmi.h > >> index f94da0e..60050c2 100644 > >> --- a/include/linux/nmi.h > >> +++ b/include/linux/nmi.h > >> @@ -80,6 +80,8 @@ extern int proc_watchdog_thresh(struct ctl_table *, int , > >> void __user *, size_t *, loff_t *); > >> extern int proc_watchdog_cpumask(struct ctl_table *, int, > >> void __user *, size_t *, loff_t *); > >> +extern int watchdog_suspend(void); > >> +extern void watchdog_resume(void); > > > > How about nmi_watchdog_enable() and nmi_watchdog_disable() to avoid confusion > > with the watchdog subsystem ? > > Guenter, > > Good point. However, I would like to avoid the 'nmi_' prefix in the > function names as it could be misleading. watchdog_{suspend|resume} > affect both -the hard and soft lockup detector- so I think function > names like > > lockup_detector_suspend() instead of watchdog_suspend() > lockup_detector_resume() instead of watchdog_resume() > > would summarize better what these functions are intended to be used > for. The above names would also be consistent with the existing name > > lockup_detector_init() > Makes sense. Thanks, Guenter