From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: v4.2-rc dcache regression, probably 75a6f82a0d10
Date: Sat, 1 Aug 2015 18:09:36 +0100
Message-ID: <20150801170936.GX17109@ZenIV.linux.org.uk>
References: <alpine.LSU.2.11.1507311022320.10162@eggly.anvils>
 <CA+55aFxGp3Hn-CeFE1NTYDr7vt3xjqe2mV1BbZ2tYHpCxenuAA@mail.gmail.com>
 <alpine.LSU.2.11.1507311207160.11122@eggly.anvils>
 <20150731205036.GA3752@nautica>
 <CA+55aFz9jj_wAjXNoFbKFbV3M1Ki2KhHuoMwQGPi0wiQjMXdsw@mail.gmail.com>
 <20150801072603.GV17109@ZenIV.linux.org.uk>
 <CA+55aFx7OY8X=s=oc5HUeWeA-5vWqkH+gcOV80xC=xXv9Q3AnQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dominique Martinet <asmadeus@codewreck.org>,
	Hugh Dickins <hughd@google.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Dominique Martinet <dominique.martinet@cea.fr>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:47229 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751292AbbHARJq (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 1 Aug 2015 13:09:46 -0400
Content-Disposition: inline
In-Reply-To: <CA+55aFx7OY8X=s=oc5HUeWeA-5vWqkH+gcOV80xC=xXv9Q3AnQ@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Aug 01, 2015 at 09:09:24AM -0700, Linus Torvalds wrote:
> On Sat, Aug 1, 2015 at 12:26 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Actually, the shit had hit the fan earlier.  Look: in
> > commit b18825a7c8e37a7cf6abb97a12a6ad71af160de7
> > Author: David Howells <dhowells@redhat.com>
> > Date:   Thu Sep 12 19:22:53 2013 +0100
> >
> >     VFS: Put a small type field into struct dentry::d_flags
> >
> > we have this:
> >
> > -               if (!can_lookup(nd->inode)) {
> > +               if (!d_is_directory(nd->path.dentry)) {
> 
> Ahh. That's subtle, yes. Inodes are stable in ways that dentries
> aren't. And the reason why Dominique bisected it to 4bf46a272647 would
> seem to be that while dentries aren't really stable, the dentry flags
> generally don't change. But dentry_iput() changed to actually clear
> the type when clearing the inode, so that probably added a few cases
> where it went from "stable in practice" to be more easily triggered.
> 
> Your patch looks obviously correct, with the slight worry that there
> might be other cases of this.
> 
> > there.  AFAICS, other places of that sort are not a problem anymore.
> 
> Al, do you plan a pull request? It would be good to get this into rc5
> (tomorrow) regardless of whether there might be other issues lurking
> too.

Will do later today.  -stable branches will be interesting, though ;-/

Al, still digging through the loads of fun stuff in l-k mailbox...