All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH resend V2 1/3] mtd: nand: mxs support oobsize bigger than 512
Date: Sat, 1 Aug 2015 17:18:10 +0200	[thread overview]
Message-ID: <201508011718.10214.marex@denx.de> (raw)
In-Reply-To: <20150801055631.GA29276@shlinux2>

On Saturday, August 01, 2015 at 07:56:39 AM, Peng Fan wrote:
> On Fri, Jul 31, 2015 at 09:36:45PM -0500, Scott Wood wrote:
> >On Sat, 2015-08-01 at 09:15 +0800, Peng Fan wrote:
> >> On Fri, Jul 31, 2015 at 12:07:50PM -0500, Scott Wood wrote:
> >> > On Tue, 2015-07-21 at 16:15 +0800, Peng Fan wrote:
> >> > > If ecc chunk data size is 512 and oobsize is bigger than 512, there
> >> > > is a chance that block_mark_bit_offset conflicts with bch ecc area.
> >> > > 
> >> > > The following graph is modified from kernel gpmi-nand.c driver with
> >> > > each data block 512 bytes. We can see that Block Mark conflicts with
> >> > > ecc area from bch view. We can enlarge the ecc chunk size to avoid
> >> > > this problem to those oobsize which is larger than 512.
> >> > 
> >> > Enlarge it by how much?  What does the layout look like in that case?
> >> 
> >> Enlarge it to 1024 bytes.
> >
> >Then say so in the changelog.
> 
> You mean I need to add this in commit msg and send out a new patch version?
> Or you pick this one?

This discussion is becoming ridiculous, can we please get this bugfix applied ?
If you don't like some minor details in the commit message, can you please fix
them while applying ?

Thanks

[...]
Best regards,
Marek Vasut

  reply	other threads:[~2015-08-01 15:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21  8:15 [U-Boot] [PATCH resend V2 1/3] mtd: nand: mxs support oobsize bigger than 512 Peng Fan
2015-07-21  8:15 ` [U-Boot] [PATCH V2 2/3] mtd: nand: mxs check maximum ecc that platfrom supports Peng Fan
2015-07-31 16:14   ` Tim Harvey
2015-08-25 21:05   ` Scott Wood
2015-08-26  0:33     ` Peng Fan
2015-08-26  2:14       ` Scott Wood
2015-08-26  1:30         ` Peng Fan
2015-08-26  7:59           ` Stefano Babic
2015-07-21  8:15 ` [U-Boot] [PATCH V2 3/3] mtd: nand: mxs invalidate dcache before DMA read Peng Fan
2015-07-21  8:41   ` Marek Vasut
2015-07-31 14:49   ` Tim Harvey
2015-07-31 15:01     ` Marek Vasut
2015-07-31 16:20 ` [U-Boot] [PATCH resend V2 1/3] mtd: nand: mxs support oobsize bigger than 512 Tim Harvey
2015-07-31 17:07 ` Scott Wood
2015-08-01  1:15   ` Peng Fan
2015-08-01  2:36     ` Scott Wood
2015-08-01  5:56       ` Peng Fan
2015-08-01 15:18         ` Marek Vasut [this message]
2015-08-01 18:32           ` Scott Wood
2015-08-01 18:38             ` Marek Vasut
2015-08-01 18:54               ` Scott Wood
2015-08-02  3:18                 ` Peng Fan
2015-08-10  1:17                   ` Peng Fan
2015-08-10 23:31                     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201508011718.10214.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.