Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Amit Shah (amit.shah@redhat.com) wrote:
> On (Fri) 31 Jul 2015 [10:59:47], Stefano Stabellini wrote:
> > On Thu, 30 Jul 2015, Stefano Stabellini wrote:
> > > On Thu, 30 Jul 2015, Juan Quintela wrote:
> > > > Anthony PERARD <anthony.perard@citrix.com> wrote:
> > > > > This is a critical issue for Xen as migration either with the same version
> > > > > of QEMU, or from a previous version of QEMU is broken.
> > > > >
> > > > > Any suggestion on how to move forward?
> > > > 
> > > > Will send a pull requset tomorrow.
> > > > 
> > > > Thinking about creating a single function that is called for all needed
> > > > places, just to avoid this problem in the future.
> > > > 
> > > 
> > > Hi Juan,
> > > 
> > > thanks for looking into this!
> > > Do you have patches already we can look at and help you test to make
> > > sure they fix the issue?
> > 
> > Any updates?
> 
> That bigger overhaul would be 2.5 stuff now.
> 
> The only thing that tripped here was the RFC tag in the subject line.
> 
> Also, I think Dave had a comment about this but I think that was made
> on IRC.  Dave, do you see a problem with this series?

Most of it is in Xen only code, so mostly no, however, the followign code looks
wrong to me:

+void global_state_store_running(void)
+{
+    const char *state = RunState_lookup[RUN_STATE_RUNNING];
+    memcpy((char *)global_state.runstate,
+           state, sizeof(global_state.runstate));
+}

Shouldn't that just be a strcpy ?

Dave

> Thanks,
> 
> 
> 		Amit
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK