All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Binbin Zhou <zhoubb@lemote.com>
Cc: John Crispin <john@phrozen.org>,
	"Steven J. Hill" <Steven.Hill@imgtec.com>,
	linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
	Zhangjin Wu <wuzhangjin@gmail.com>,
	Kelvin Cheung <keguang.zhang@gmail.com>,
	Chunbo Cui <cuicb@lemote.com>, Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH v2 3/8] MIPS: Loongson: Add platform devices for Loongson-1A/1B
Date: Mon, 3 Aug 2015 17:21:07 +0200	[thread overview]
Message-ID: <20150803152107.GE2843@linux-mips.org> (raw)
In-Reply-To: <1434537166-5385-4-git-send-email-zhoubb@lemote.com>

On Wed, Jun 17, 2015 at 06:32:41PM +0800, Binbin Zhou wrote:

>  arch/mips/loongson32/common/platform.c            | 290 +++++++++++++++++++++-

Another lengthy platform.c file.  Have you considered putting that
information into a DT instead?

  Ralf

  reply	other threads:[~2015-08-03 15:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 10:32 [PATCH v2 0/8] MIPS: Loongson: Add the Loongson-1A processor support Binbin Zhou
2015-06-17 10:32 ` [PATCH v2 1/8] MIPS: Loongson: Add basic Loongson-1A CPU support Binbin Zhou
2015-06-17 10:32 ` [PATCH v2 2/8] MIPS: Loongson: Add Loongson-1A Kconfig options Binbin Zhou
2015-06-17 10:32 ` [PATCH v2 3/8] MIPS: Loongson: Add platform devices for Loongson-1A/1B Binbin Zhou
2015-08-03 15:21   ` Ralf Baechle [this message]
2015-08-04  3:15     ` Huacai Chen
2015-06-17 10:32 ` [PATCH v2 4/8] MIPS: Loongson: Add loongson-1A board support Binbin Zhou
2015-06-17 10:32 ` [PATCH v2 5/8] MIPS: Loongson-1A: Workaround for pll register can't be read Binbin Zhou
2015-06-17 10:32 ` [PATCH v2 6/8] MIPS: Loongson-1A: Add IRQ type setting support Binbin Zhou
2015-06-17 10:32 ` [PATCH v2 7/8] MIPS: Loongson-1A: Enable SPARSEMEN and HIGHMEM Binbin Zhou
2015-06-17 10:32 ` [PATCH v2 8/8] MIPS: Loongson: Add a Loongson-1A default config file Binbin Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150803152107.GE2843@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=Steven.Hill@imgtec.com \
    --cc=chenhc@lemote.com \
    --cc=cuicb@lemote.com \
    --cc=john@phrozen.org \
    --cc=keguang.zhang@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=wuzhangjin@gmail.com \
    --cc=zhangfx@lemote.com \
    --cc=zhoubb@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.