From: Joerg Roedel <joro@8bytes.org>
To: "Salva Peiró" <speirofr@gmail.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/omap: Fix debug_read_tlb() to use seq_printf()
Date: Mon, 3 Aug 2015 17:25:58 +0200 [thread overview]
Message-ID: <20150803152557.GF20968@8bytes.org> (raw)
In-Reply-To: <1437654379-13356-1-git-send-email-speirofr@gmail.com>
On Thu, Jul 23, 2015 at 02:26:19PM +0200, Salva Peiró wrote:
> The debug_read_tlb() uses the sprintf() functions directly on the buffer
> allocated by buf = kmalloc(count), without taking into account the size
> of the buffer, with the consequence corrupting the heap, depending on
> the count requested by the user.
>
> The patch fixes the issue replacing sprintf() by seq_printf().
>
> Signed-off-by: Salva Peiró <speirofr@gmail.com>
> ---
> drivers/iommu/omap-iommu-debug.c | 26 +++++++-------------------
> drivers/iommu/omap-iommu.c | 28 +++++++++++-----------------
> drivers/iommu/omap-iommu.h | 3 +--
> 3 files changed, 19 insertions(+), 38 deletions(-)
Applied, thanks. I had to rebase it on top of Suman's changes, but that
wasn't too hard.
prev parent reply other threads:[~2015-08-03 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 12:26 [PATCH] iommu/omap: Fix debug_read_tlb() to use seq_printf() Salva Peiró
2015-08-03 15:25 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803152557.GF20968@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=speirofr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.