From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver
Date: Mon, 03 Aug 2015 15:46:45 +0000 [thread overview]
Message-ID: <20150803154645.GV5096@mwanda> (raw)
In-Reply-To: <20150803153921.GA13117@mwanda>
There are some other Smatch warnings as well:
drivers/net/usb/lan78xx.c:2302 lan78xx_start_xmit() error: we previously assumed 'skb' could be null (see line 2299)
skb is dereferenced inside the function call.
drivers/net/usb/lan78xx.c:2885 lan78xx_bh() info: ignoring unreachable code.
drivers/net/usb/lan78xx.c:3159 lan78xx_probe() info: ignoring unreachable code.
These are calls to BUG_ON(). You should just delete it, network
drivers shouldn't call BUG_ON(), at most they should call WARN_ON().
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-03 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 15:39 Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver Dan Carpenter
2015-08-03 15:46 ` Dan Carpenter [this message]
2015-08-03 15:48 ` Woojung.Huh
2015-08-03 16:06 ` Dan Carpenter
2015-08-03 16:07 ` Woojung.Huh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803154645.GV5096@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.