From: Rabin Vincent <rabin@rab.in>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: etraxfs: add interrupt support
Date: Mon, 3 Aug 2015 19:30:40 +0200 [thread overview]
Message-ID: <20150803173005.GA28817@debian> (raw)
In-Reply-To: <CACRpkdZOztPHykq99bC0P9t0jQkAdYqrrbC2shwWa9d2O5DQXw@mail.gmail.com>
On Mon, Aug 03, 2015 at 11:34:23AM +0200, Linus Walleij wrote:
> On Fri, Jul 31, 2015 at 2:48 PM, Rabin Vincent <rabin@rab.in> wrote:
> > +static void etraxfs_gpio_irq_ack(struct irq_data *d)
> > +{
> > + struct etraxfs_gpio_chip *chip = irq_data_get_irq_chip_data(d);
>
> I don't see how this works in the irqchip functions.
The offset of the gpio_chip embedded in etraxfs_gpio_chip is zero.
There are a couple of other gpio drivers doing it the same way, but
container_of() would certainly be more robust.
next prev parent reply other threads:[~2015-08-03 17:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 12:48 [PATCH 1/2] gpio: don't override irq_*_resources() callbacks Rabin Vincent
2015-07-31 12:48 ` [PATCH 2/2] gpio: etraxfs: add interrupt support Rabin Vincent
2015-08-03 8:58 ` Linus Walleij
2015-08-03 9:34 ` Linus Walleij
2015-08-03 17:30 ` Rabin Vincent [this message]
2015-08-13 8:57 ` Linus Walleij
2015-07-31 14:54 ` [PATCH 1/2] gpio: don't override irq_*_resources() callbacks Grygorii Strashko
2015-07-31 14:54 ` Grygorii Strashko
2015-08-03 8:56 ` Linus Walleij
2015-08-03 8:53 ` Linus Walleij
2015-08-17 8:40 ` Geert Uytterhoeven
2015-08-17 13:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803173005.GA28817@debian \
--to=rabin@rab.in \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.