Re: vm_flags, vm_flags_t and __nocast

[Oleg Nesterov <oleg@redhat.com>]

On 08/03, Kirill A. Shutemov wrote:
>
> Subject: [PATCH] mm: drop __nocast from vm_flags_t definition
>
> __nocast does no good for vm_flags_t. It only produces useless sparse
> warnings.
>
> Let's drop it.

Personally I like this change.

I too see no value in this "__nocast".

> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  include/linux/mm_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 1fb4e46a1736..b9134cc27c4d 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -226,7 +226,7 @@ struct page_frag {
>  #endif
>  };
>  
> -typedef unsigned long __nocast vm_flags_t;
> +typedef unsigned long vm_flags_t;
>  
>  /*
>   * A region containing a mapping of a non-memory backed file under NOMMU
> -- 
> 2.4.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>