Re: [PATCHv v2] Input: zforce - make the interrupt GPIO optional

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Mon, Aug 03, 2015 at 09:54:49AM +0200, Heiko Stübner wrote:
> Hi Dirk,
> 
> Am Montag, 3. August 2015, 08:34:06 schrieb Dirk Behme:
> > Add support for hardware which uses an I2C Serializer / Deserializer
> > (SerDes) to communicate with the zFroce touch driver. In this case the
> > SerDes will be configured as an interrupt controller and the zForce driver
> > will have no access to poll the GPIO line.
> > 
> > To support this, we add two dedicated new GPIOs in the device tree:
> > reset-gpio and irq-gpio. With the irq-gpio being optional, then.
> > 
> > To not break the existing device trees, the index based 'gpios' entries
> > are still supported, but marked as deprecated.
> > 
> > With this, if the interrupt GPIO is available, either via the old or new
> > device tree style, the while loop will read and handle the packets as long
> > as the GPIO indicates that the interrupt is asserted (existing, unchanged
> > driver behavior).
> > 
> > If the interrupt GPIO isn't available, i.e. not configured via the new
> > device tree style, we are falling back to one read per ISR invocation
> > (new behavior to support the SerDes).
> > 
> > Note that the gpiod functions help to handle the optional GPIO:
> > devm_gpiod_get_index_optional() will return NULL in case the interrupt
> > GPIO isn't available. And gpiod_get_value_cansleep() does cover this, too,
> > by returning 0 in this case.
> > 
> > Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> 
> looks nice now in v2, thanks :-)
> 
> Reviewed-by: Heiko Stuebner <heiko.stuebner@bq.com>

Applied, thank you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html