From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, eranian@google.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing
Date: Tue, 4 Aug 2015 02:41:11 +0200 [thread overview]
Message-ID: <20150804004111.GV1747@two.firstfloor.org> (raw)
In-Reply-To: <20150730134755.GP9606@krava.brq.redhat.com>
>
> because we already need to make the print_metric callback global,
> would it be better to make this struct global, having all the
> needed callbacks defined within? something like:
It's actually not global, but static.
I skipped this change. After some other changes there is only
a single function call with these arguments left, so it's not
an issue to pass it around.
-Andi
next prev parent reply other threads:[~2015-08-04 0:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 0:21 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2015-07-30 0:21 ` [PATCH 1/4] perf, tools: Do not include escape sequences in color_vfprintf return Andi Kleen
2015-07-30 12:35 ` [PATCH] perf tools: Remove color_fprintf_ln function Jiri Olsa
2015-07-30 0:21 ` [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-07-30 13:42 ` Jiri Olsa
2015-07-30 13:47 ` Jiri Olsa
2015-08-04 0:41 ` Andi Kleen [this message]
2015-08-08 17:40 ` Jiri Olsa
2015-07-30 0:21 ` [PATCH 3/4] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-07-30 13:53 ` Jiri Olsa
2015-07-30 0:21 ` [PATCH 4/4] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-07-30 14:06 ` Jiri Olsa
2015-07-30 14:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804004111.GV1747@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.