From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMXpH-0000T3-GK for qemu-devel@nongnu.org; Tue, 04 Aug 2015 04:44:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMXpC-0002pi-RJ for qemu-devel@nongnu.org; Tue, 04 Aug 2015 04:43:57 -0400 Received: from mail.ispras.ru ([83.149.199.45]:56189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMXpC-0002pQ-Ke for qemu-devel@nongnu.org; Tue, 04 Aug 2015 04:43:54 -0400 From: Pavel Dovgalyuk Date: Tue, 04 Aug 2015 11:43:55 +0300 Message-ID: <20150804084354.7280.55091.stgit@PASHA-ISP> In-Reply-To: <20150804084345.7280.75100.stgit@PASHA-ISP> References: <20150804084345.7280.75100.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v16 01/21] i386: partial revert of interrupt poll fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, igor.rubinov@gmail.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, hines@cert.org, fred.konrad@greensocs.com Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c | 6 ++++++ target-i386/cpu.c | 10 ++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 2ebf454..fd59a52 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -373,6 +373,12 @@ int cpu_exec(CPUState *cpu) volatile bool have_tb_lock = false; if (cpu->halted) { +#ifdef TARGET_I386 + if (cpu->interrupt_request & CPU_INTERRUPT_POLL) { + apic_poll_irq(x86_cpu->apic_state); + cpu_reset_interrupt(cpu, CPU_INTERRUPT_POLL); + } +#endif if (!cpu_has_work(cpu)) { return EXCP_HALTED; } diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7a779b1..3635cfe 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3124,14 +3124,8 @@ static bool x86_cpu_has_work(CPUState *cs) X86CPU *cpu = X86_CPU(cs); CPUX86State *env = &cpu->env; -#if !defined(CONFIG_USER_ONLY) - if (cs->interrupt_request & CPU_INTERRUPT_POLL) { - apic_poll_irq(cpu->apic_state); - cpu_reset_interrupt(cs, CPU_INTERRUPT_POLL); - } -#endif - - return ((cs->interrupt_request & CPU_INTERRUPT_HARD) && + return ((cs->interrupt_request & (CPU_INTERRUPT_HARD | + CPU_INTERRUPT_POLL)) && (env->eflags & IF_MASK)) || (cs->interrupt_request & (CPU_INTERRUPT_NMI | CPU_INTERRUPT_INIT |