From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org,
Timo Kokkonen <timo.kokkonen@offcode.fi>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives
Date: Tue, 4 Aug 2015 17:44:22 +0200 [thread overview]
Message-ID: <20150804154422.GU9999@pengutronix.de> (raw)
In-Reply-To: <1438654414-29259-6-git-send-email-linux@roeck-us.net>
Hello,
On Mon, Aug 03, 2015 at 07:13:31PM -0700, Guenter Roeck wrote:
> The watchdog infrastructure now supports handling watchdog keepalive
> if the watchdog is running while the watchdog device is closed.
> Convert the driver to use this infrastructure.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/imx2_wdt.c | 72 ++++++++-------------------------------------
I tested the series on an i.MX27 machine and it works nicely. When the
watchdog is already running at probe time it is constantly pinged until
userspace opens /dev/watchdog. With the patch I sent earlier today the
functionallity is also given, that is the machine resets iff I stop
pinging. And when I do a stopping-close the worker looks for this in
hardware non-stoppable device.
Very nice, and also \o/ for the diffstat,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-08-04 15:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 2:13 [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure Guenter Roeck
2015-08-04 2:13 ` [PATCH 1/8] watchdog: watchdog_dev: Use single variable name for struct watchdog_device Guenter Roeck
2015-08-04 11:26 ` Uwe Kleine-König
2015-08-04 2:13 ` [PATCH 2/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck
2015-08-04 12:18 ` Uwe Kleine-König
2015-08-04 15:31 ` Guenter Roeck
2015-08-04 15:31 ` Guenter Roeck
2015-08-04 15:52 ` Uwe Kleine-König
2015-08-04 16:03 ` Guenter Roeck
2015-08-05 8:22 ` Uwe Kleine-König
2015-08-05 9:14 ` Guenter Roeck
2015-08-04 2:13 ` [PATCH 3/8] watchdog: Introduce WDOG_RUNNING flag Guenter Roeck
2015-08-04 12:25 ` Uwe Kleine-König
2015-08-04 15:41 ` Uwe Kleine-König
2015-08-04 15:56 ` Guenter Roeck
2015-08-04 2:13 ` [PATCH 4/8] watchdog: Make set_timeout function optional Guenter Roeck
2015-08-04 15:38 ` Uwe Kleine-König
2015-08-04 16:43 ` Guenter Roeck
2015-08-04 2:13 ` [PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives Guenter Roeck
2015-08-04 15:44 ` Uwe Kleine-König [this message]
2015-08-04 2:13 ` [PATCH 6/8] watchdog: retu: " Guenter Roeck
2015-08-04 2:13 ` [PATCH 7/8] watchdog: gpio_wdt: " Guenter Roeck
2015-08-04 2:13 ` [PATCH 8/8] watchdog: at91sam9: " Guenter Roeck
2015-08-04 11:24 ` [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure Uwe Kleine-König
2015-08-04 15:01 ` Guenter Roeck
2015-08-04 23:43 ` Pádraig Brady
2015-08-05 0:49 ` Guenter Roeck
2015-08-05 7:36 ` Uwe Kleine-König
2015-08-05 7:50 ` Guenter Roeck
2015-08-05 7:50 ` Guenter Roeck
2015-08-05 8:27 ` Uwe Kleine-König
2015-08-05 17:13 ` David Teigland
2015-08-05 17:41 ` Guenter Roeck
2015-08-05 17:51 ` David Teigland
2015-08-05 19:01 ` Guenter Roeck
2015-08-05 19:51 ` David Teigland
2015-08-05 20:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804154422.GU9999@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=timo.kokkonen@offcode.fi \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.