From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
Cc: rogerq-l0cyMroinI0@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
t-kristo-l0cyMroinI0@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
nsekhar-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()
Date: Tue, 4 Aug 2015 11:00:28 -0500 [thread overview]
Message-ID: <20150804160028.GG23659@saruman.tx.rr.com> (raw)
In-Reply-To: <1438701646-7876-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote:
> No functional change. Add separate functions for pll,
> clocks and syscon to make ti_pipe3_probe clean.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
I think this needs to be splitted into smaller patches.
Seems like the very first patch would be to introduce a local struct
device pointer to be used. Than add each and every new function on their
own patch. This will help big time making your refactoring a lot clearer
and, should anything go wrong, we can atomically revert a specific
change, instead of loosing the entire refactor.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: <rogerq@ti.com>, <tony@atomide.com>, <t-kristo@ti.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<balbi@ti.com>, <nsekhar@ti.com>
Subject: Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()
Date: Tue, 4 Aug 2015 11:00:28 -0500 [thread overview]
Message-ID: <20150804160028.GG23659@saruman.tx.rr.com> (raw)
In-Reply-To: <1438701646-7876-2-git-send-email-kishon@ti.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote:
> No functional change. Add separate functions for pll,
> clocks and syscon to make ti_pipe3_probe clean.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
I think this needs to be splitted into smaller patches.
Seems like the very first patch would be to introduce a local struct
device pointer to be used. Than add each and every new function on their
own patch. This will help big time making your refactoring a lot clearer
and, should anything go wrong, we can atomically revert a specific
change, instead of loosing the entire refactor.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-04 16:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 15:20 [PATCH 0/7] phy: use syscon framework APIs to set ctrl mod reg Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
2015-08-04 15:20 ` [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe() Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
[not found] ` <1438701646-7876-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-08-04 16:00 ` Felipe Balbi [this message]
2015-08-04 16:00 ` Felipe Balbi
[not found] ` <20150804160028.GG23659-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-05 14:08 ` Kishon Vijay Abraham I
2015-08-05 14:08 ` Kishon Vijay Abraham I
2015-08-04 15:20 ` [PATCH 2/7] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
2015-08-04 16:06 ` Felipe Balbi
2015-08-04 16:06 ` Felipe Balbi
[not found] ` <20150804160631.GH23659-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-08-05 14:12 ` Kishon Vijay Abraham I
2015-08-05 14:12 ` Kishon Vijay Abraham I
2015-08-05 15:35 ` Felipe Balbi
2015-08-05 15:35 ` Felipe Balbi
2015-08-04 15:20 ` [PATCH 3/7] phy: ti-pipe3: use *syscon* framework API to power on/off the PHY Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
[not found] ` <1438701646-7876-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-08-04 15:20 ` [PATCH 4/7] phy: ti-pipe3: use *syscon* framework API to set PCS value of " Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
2015-08-04 15:20 ` [PATCH 5/7] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
2015-08-04 16:07 ` Felipe Balbi
2015-08-04 16:07 ` Felipe Balbi
2015-08-04 15:20 ` [PATCH 6/7] phy: omap-usb2: Add a new compatible string for USB2 PHY2 Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
[not found] ` <1438701646-7876-7-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2015-08-05 8:23 ` Roger Quadros
2015-08-05 8:23 ` Roger Quadros
2015-08-05 8:25 ` Roger Quadros
2015-08-05 8:25 ` Roger Quadros
2015-08-05 14:18 ` Kishon Vijay Abraham I
2015-08-05 14:18 ` Kishon Vijay Abraham I
2015-08-07 8:27 ` Roger Quadros
2015-08-07 8:27 ` Roger Quadros
2015-08-04 15:20 ` [PATCH 7/7] phy: omap-usb2: use *syscon* framework API to power on/off the PHY Kishon Vijay Abraham I
2015-08-04 15:20 ` Kishon Vijay Abraham I
2015-08-05 8:35 ` Roger Quadros
2015-08-05 8:35 ` Roger Quadros
[not found] ` <55C1CAE1.3060901-l0cyMroinI0@public.gmane.org>
2015-08-05 14:21 ` Kishon Vijay Abraham I
2015-08-05 14:21 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804160028.GG23659@saruman.tx.rr.com \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.